This is the last bit of "python" left in the notmuch codebase. https://www.python.org/dev/peps/pep-0394/#recommendation encourages "third-party distributors" to use more-specific shebang lines. I'm not certain that the notmuch project itself is a "third-party contributor" but I think this is a safe way to encourage people to use python3 when they're developing notmuch. We already have python3 explicitly elsewhere in the codebase for developers (in nmbug). Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> --- bindings/python/setup.py | 2 +- test/json_check_nodes.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings/python/setup.py b/bindings/python/setup.py index d986f0c6..6308b9f9 100644 --- a/bindings/python/setup.py +++ b/bindings/python/setup.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 """ This file is part of notmuch. diff --git a/test/json_check_nodes.py b/test/json_check_nodes.py index 17403c57..fd8f1607 100755 --- a/test/json_check_nodes.py +++ b/test/json_check_nodes.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 import re import sys import json -- 2.30.0
On Fri, Feb 12 2021, Daniel Kahn Gillmor wrote: > This is the last bit of "python" left in the notmuch codebase. > > https://www.python.org/dev/peps/pep-0394/#recommendation encourages > "third-party distributors" to use more-specific shebang lines. I'm > not certain that the notmuch project itself is a "third-party > contributor" but I think this is a safe way to encourage people to use > python3 when they're developing notmuch. > > We already have python3 explicitly elsewhere in the codebase for > developers (in nmbug). LGTM Tomi > > Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net> > --- > bindings/python/setup.py | 2 +- > test/json_check_nodes.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bindings/python/setup.py b/bindings/python/setup.py > index d986f0c6..6308b9f9 100644 > --- a/bindings/python/setup.py > +++ b/bindings/python/setup.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > > """ > This file is part of notmuch. > diff --git a/test/json_check_nodes.py b/test/json_check_nodes.py > index 17403c57..fd8f1607 100755 > --- a/test/json_check_nodes.py > +++ b/test/json_check_nodes.py > @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > import re > import sys > import json > -- > 2.30.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org
Tomi Ollila <tomi.ollila@iki.fi> writes:
> On Fri, Feb 12 2021, Daniel Kahn Gillmor wrote:
>
>> This is the last bit of "python" left in the notmuch codebase.
>>
>> https://www.python.org/dev/peps/pep-0394/#recommendation encourages
>> "third-party distributors" to use more-specific shebang lines. I'm
>> not certain that the notmuch project itself is a "third-party
>> contributor" but I think this is a safe way to encourage people to use
>> python3 when they're developing notmuch.
>>
>> We already have python3 explicitly elsewhere in the codebase for
>> developers (in nmbug).
>
> LGTM
>
> Tomi
>
Applied to master.
d