unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / Atom feed
* [PATCH] python: convert shebangs to python3
@ 2021-02-13  0:26 Daniel Kahn Gillmor
  2021-02-13  8:30 ` Tomi Ollila
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kahn Gillmor @ 2021-02-13  0:26 UTC (permalink / raw)
  To: Notmuch Mail

This is the last bit of "python" left in the notmuch codebase.

https://www.python.org/dev/peps/pep-0394/#recommendation encourages
"third-party distributors" to use more-specific shebang lines.  I'm
not certain that the notmuch project itself is a "third-party
contributor" but I think this is a safe way to encourage people to use
python3 when they're developing notmuch.

We already have python3 explicitly elsewhere in the codebase for
developers (in nmbug).

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 bindings/python/setup.py | 2 +-
 test/json_check_nodes.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/bindings/python/setup.py b/bindings/python/setup.py
index d986f0c6..6308b9f9 100644
--- a/bindings/python/setup.py
+++ b/bindings/python/setup.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 """
 This file is part of notmuch.
diff --git a/test/json_check_nodes.py b/test/json_check_nodes.py
index 17403c57..fd8f1607 100755
--- a/test/json_check_nodes.py
+++ b/test/json_check_nodes.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 import re
 import sys
 import json
-- 
2.30.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] python: convert shebangs to python3
  2021-02-13  0:26 [PATCH] python: convert shebangs to python3 Daniel Kahn Gillmor
@ 2021-02-13  8:30 ` Tomi Ollila
  2021-02-15 20:40   ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Tomi Ollila @ 2021-02-13  8:30 UTC (permalink / raw)
  To: Daniel Kahn Gillmor, Notmuch Mail

On Fri, Feb 12 2021, Daniel Kahn Gillmor wrote:

> This is the last bit of "python" left in the notmuch codebase.
>
> https://www.python.org/dev/peps/pep-0394/#recommendation encourages
> "third-party distributors" to use more-specific shebang lines.  I'm
> not certain that the notmuch project itself is a "third-party
> contributor" but I think this is a safe way to encourage people to use
> python3 when they're developing notmuch.
>
> We already have python3 explicitly elsewhere in the codebase for
> developers (in nmbug).

LGTM

Tomi

>
> Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
> ---
>  bindings/python/setup.py | 2 +-
>  test/json_check_nodes.py | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bindings/python/setup.py b/bindings/python/setup.py
> index d986f0c6..6308b9f9 100644
> --- a/bindings/python/setup.py
> +++ b/bindings/python/setup.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  
>  """
>  This file is part of notmuch.
> diff --git a/test/json_check_nodes.py b/test/json_check_nodes.py
> index 17403c57..fd8f1607 100755
> --- a/test/json_check_nodes.py
> +++ b/test/json_check_nodes.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>  import re
>  import sys
>  import json
> -- 
> 2.30.0
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] python: convert shebangs to python3
  2021-02-13  8:30 ` Tomi Ollila
@ 2021-02-15 20:40   ` David Bremner
  0 siblings, 0 replies; 3+ messages in thread
From: David Bremner @ 2021-02-15 20:40 UTC (permalink / raw)
  To: Tomi Ollila, Daniel Kahn Gillmor, Notmuch Mail

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Fri, Feb 12 2021, Daniel Kahn Gillmor wrote:
>
>> This is the last bit of "python" left in the notmuch codebase.
>>
>> https://www.python.org/dev/peps/pep-0394/#recommendation encourages
>> "third-party distributors" to use more-specific shebang lines.  I'm
>> not certain that the notmuch project itself is a "third-party
>> contributor" but I think this is a safe way to encourage people to use
>> python3 when they're developing notmuch.
>>
>> We already have python3 explicitly elsewhere in the codebase for
>> developers (in nmbug).
>
> LGTM
>
> Tomi
>

Applied to master.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-15 20:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-13  0:26 [PATCH] python: convert shebangs to python3 Daniel Kahn Gillmor
2021-02-13  8:30 ` Tomi Ollila
2021-02-15 20:40   ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git