From: Jose Antonio Ortega Ruiz <jao@gnu.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: notmuch-tree: customizable strings for drawing trees
Date: Mon, 30 Aug 2021 19:43:36 +0100 [thread overview]
Message-ID: <87fsuqbwo7.fsf@gnus.jao.io> (raw)
In-Reply-To: <87pmtv54gf.fsf@tethera.net>
On Mon, Aug 30 2021, David Bremner wrote:
> jao <jao@gnu.org> writes:
>
>> +(defcustom notmuch-tree-thread-symbols '(" " "─" "┬" "│" "├" "╰" "►")
>
> How hard would it be to use a plist or an alist, and allow the user to
> overide only the symbols they are interested in?
not hard at all... we just need to figure out good names (suggestions
welcome). i think i'd prefer an alist, but it's not a strong preference
if you'd rather have a plist.
>> + (push (elt notmuch-tree-thread-symbols 4) tree-status))
>
> As hinted above, I don't love the intriduction of magic indices,
> although I guess it might be tolerable if they are used only in one place.
yes, i agree. i even had some code where i had variables for those
indices, but felt a bit overkill for things used in just one place. but
using a plist/alist would give us what we need here.
next prev parent reply other threads:[~2021-08-30 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 23:58 [PATCH] emacs: notmuch-tree: customizable strings for drawing trees jao
2021-08-23 0:06 ` Jose Antonio Ortega Ruiz
2021-08-30 15:37 ` David Bremner
2021-08-30 18:43 ` Jose Antonio Ortega Ruiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-21 1:55 jao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsuqbwo7.fsf@gnus.jao.io \
--to=jao@gnu.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).