From: David Bremner <david@tethera.net>
To: Kevin Boulain <kevin@boula.in>, notmuch@notmuchmail.org
Cc: Kevin Boulain <kevin@boula.in>
Subject: Re: [PATCH 2/2] lib: thread-safe s-expression query parser
Date: Sat, 22 Jul 2023 16:06:22 -0300 [thread overview]
Message-ID: <87fs5fg40h.fsf@tethera.net> (raw)
In-Reply-To: <20230403203146.39749-2-kevin@boula.in>
Kevin Boulain <kevin@boula.in> writes:
> +
> +inline Xapian::Query
> +_sexp_initial_query (_sexp_initial_t initial)
My first thought was that this should be static, but maybe it doesn't
matter in C++; I see the other inline functions in that file are not
declared static.
> + }
> + assert (! "unreachable");
I stumbled over the logic this code. I would prefer not to use assert
for this. In a few other places we call INTERNAL_ERROR from a default:
case.
Other than those quibbles, the change looks reasonable. I'm unsure how
to test it though.
next prev parent reply other threads:[~2023-07-22 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:31 [PATCH 1/2] test: showcase thread-unsafe s-expression query parser Kevin Boulain
2023-04-03 20:31 ` [PATCH 2/2] lib: thread-safe " Kevin Boulain
2023-07-22 19:06 ` David Bremner [this message]
2023-08-27 12:31 ` [PATCH v2 1/2] test: showcase thread-unsafe " Kevin Boulain
2023-09-19 10:30 ` David Bremner
2023-08-27 12:31 ` [PATCH v2 2/2] lib: thread-safe " Kevin Boulain
2024-07-25 10:23 ` David Bremner
2023-08-27 12:33 ` [PATCH " Kevin Boulain
2023-07-22 18:48 ` [PATCH 1/2] test: showcase thread-unsafe " David Bremner
2023-07-23 13:23 ` Michael J Gruber
2023-07-23 14:03 ` David Bremner
2023-08-06 10:05 ` Kevin Boulain
2023-08-06 12:01 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs5fg40h.fsf@tethera.net \
--to=david@tethera.net \
--cc=kevin@boula.in \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).