unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] Make the date parser nicer
Date: Wed, 27 Jan 2010 10:15:46 +0100	[thread overview]
Message-ID: <87eilbewn1.fsf@SSpaeth.de> (raw)
In-Reply-To: <yunockgoiob.fsf@aiko.keithp.com>

On Tue, 26 Jan 2010 09:55:00 -0800, Keith Packard <keithp@keithp.com> wrote:
> Very cool. Oh, if you've got commits that don't compile on their own,
> you should squash them together (or fix it in some other way). Makes
> bisecting easier in the future.

Makes sense. I am still quite new to git, so excuse those beginner's
lapses. Perhaps Carl could squash commits ec3c79a and 2565fc6 when (if?)
pulling, that would make every step compile IMHO.

> Also, cworth is on vacation this week, so we won't be seeing any
> merging to master...

No hurry :-). cworth will have to do quite some catching up when he
returns.

The one "disadvantage" my integration has over your original approach,
is that we now always require "date:XXX..YYY". A 'date:lastmonth' won't
work, it will need to be "date:lastmonth..today". The reason is that
xapian only seems to invoke the RangeParser when something of the format
'A..B' is passed as a parameter. So while we could get "date:..2005" to
work, "date:2005.." is not passed to the RangeParser handler, it seems.
 
We could ditch the "date:" prefix, but imho it is more consistent with
the other keywords to use it. I have no strong feelings about this.

It also still has the same limitation, in that it will not find emails with
a future timestamp (I use date:lastweek..5000 to get all mails with a
future stamp).

Sebastian

      reply	other threads:[~2010-01-27  9:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 15:26 [PATCH] Make the date parser nicer Sebastian Spaeth
2010-01-22 15:33 ` Sebastian Spaeth
2010-01-22 16:04 ` Sebastian Spaeth
2010-01-24 14:13 ` Sebastian Spaeth
2010-01-25 10:50   ` [PATCH] Make the date parser nicer. This is v3 and considered to be final (but the documentation) Sebastian Spaeth
2010-01-25 12:22     ` [PATCH] Make the date parser nicer (v3 + 'now' keyword) Sebastian Spaeth
2010-01-25 13:14       ` [PATCH] Make the date parser nicer (v3 + 'now' keyword) (final mail) Sebastian Spaeth
2010-01-26  6:36 ` [PATCH] Make the date parser nicer Keith Packard
2010-01-26  9:12   ` Sebastian Spaeth
2010-01-26 11:50   ` Sebastian Spaeth
2010-01-26 17:55     ` Keith Packard
2010-01-27  9:15       ` Sebastian Spaeth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eilbewn1.fsf@SSpaeth.de \
    --to=sebastian@sspaeth.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).