From: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
To: Olly Betts <olly@survex.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] allow to not sort the search results
Date: Fri, 16 Apr 2010 08:37:04 +0200 [thread overview]
Message-ID: <87eiifj433.fsf@SSpaeth.de> (raw)
In-Reply-To: <loom.20100415T144148-25@post.gmane.org>
On 2010-04-15, Olly Betts wrote:
> > I would be happy to have it called --sort=relevance too, the unsorted
> > points out potential performance improvements a bit better, IMHO
> > (although they seem to be really small with a warm cache).
>
> When using the results of a search to add/remove tags, there's likely to be
> an additional win from --sort=unsorted as documents will now be processed
> in docid order which will tend to have a more cache friendly locality of
> access.
Olly was right in that even for "notmuch tag" we were sorting the
results by date before applying tag changes. I have slightly reworked my
patch to have notmuch tag avoid doing that. I also split up the patch in
3 patches that do one thing each.
The patches do:
1: Introduce NOTMUCH_SORT_UNSORTED
2: Introduce notmuch search --sort=unsorted
3: Make notmuch tag not sort results by date
#2 is the one I am least sure about, I don't know if there is a use case
for notmuch search returning unsorted results. But 1 & 3 are useful at
least.
> Also, sorting by relevance requires more calculations and may require fetching
> additional data (document length for example).
>
> So I think it would make sense for --sort=relevance and --sort=unsorted to be
> separate options.
Now I am a bit confused. The API docs state that sort_by_relevance is
the default. So by skipping any sort_by_value() will that incur the additional
calculations (with our BoolWeight set?). All I want is the fasted way
to return a searched set of docs :-).
Patches 1-3 follow as reply to this one
Sebastian
next prev parent reply other threads:[~2010-04-16 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 6:30 [PATCH] allow to not sort the search results Sebastian Spaeth
2010-04-14 6:55 ` Jason White
2010-04-14 7:51 ` Sebastian Spaeth
2010-04-15 12:54 ` Olly Betts
2010-04-16 6:37 ` Sebastian Spaeth [this message]
2010-04-16 6:38 ` [PATCH 1/3] query.cc: allow to return query results unsorted Sebastian Spaeth
2010-04-16 6:38 ` [PATCH 2/3] notmuch-search: Introduce --sort=unsorted Sebastian Spaeth
2010-04-16 6:38 ` [PATCH 3/3] notmuch-tag: don't sort messages before applying tag changes Sebastian Spaeth
2010-04-16 6:58 ` [PATCH] allow to not sort the search results Olly Betts
2010-04-18 13:56 ` Sebastian Spaeth
2010-04-21 23:09 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eiifj433.fsf@SSpaeth.de \
--to=sebastian@sspaeth.de \
--cc=notmuch@notmuchmail.org \
--cc=olly@survex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).