From: Jameson Rollins <jrollins@finestructure.net>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/4] Import date/time parser from GNU coreutils
Date: Mon, 24 Jan 2011 13:25:18 -0800 [thread overview]
Message-ID: <87ei82uh8h.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1295783247-21900-2-git-send-email-sojkam1@fel.cvut.cz>
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
On Sun, 23 Jan 2011 12:47:24 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> This function have quite a lot dependencies. We may reduce them later it
> it is a problem.
> ---
> lib/c-ctype.c | 398 +++++++
> lib/c-ctype.h | 297 +++++
> lib/getdate.c | 3497 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> lib/getdate.h | 22 +
> lib/getdate.y | 1572 +++++++++++++++++++++++++
> lib/gettime.c | 48 +
> lib/intprops.h | 83 ++
> lib/timespec.h | 39 +
> lib/verify.h | 140 +++
> 9 files changed, 6096 insertions(+), 0 deletions(-)
> create mode 100644 lib/c-ctype.c
> create mode 100644 lib/c-ctype.h
> create mode 100644 lib/getdate.c
> create mode 100644 lib/getdate.h
> create mode 100644 lib/getdate.y
> create mode 100644 lib/gettime.c
> create mode 100644 lib/gettime.h
> create mode 100644 lib/intprops.h
> create mode 100644 lib/timespec.h
> create mode 100644 lib/verify.h
Hi, Michal. I don't fully understand what's going on here, but it seems
like you're embedding code copies from somewhere else. If that's the
case, is there a reason that we would need to do that, rather than just
linking against an external library?
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-01-24 21:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 11:47 [PATCH 0/4] Versatile date/time parser Michal Sojka
2011-01-23 11:47 ` [PATCH 1/4] Import date/time parser from GNU coreutils Michal Sojka
2011-01-24 21:25 ` Jameson Rollins [this message]
2011-01-25 8:41 ` Michal Sojka
2011-01-23 11:47 ` [PATCH 2/4] Compile the date/time parser into notmuch library Michal Sojka
2011-01-23 11:47 ` [PATCH 3/4] Use the time/date parser for after: and before: prefixes Michal Sojka
2011-01-23 11:47 ` [PATCH 4/4] Add first date parser tests Michal Sojka
2011-01-29 4:09 ` [PATCH 0/4] Versatile date/time parser Tom Prince
2011-01-29 18:50 ` Michal Sojka
2011-01-29 19:13 ` Austin Clements
2011-02-01 8:34 ` Michal Sojka
2011-01-29 19:37 ` Sebastian Spaeth
2011-02-01 8:36 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei82uh8h.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).