From: Carl Worth <cworth@cworth.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output
Date: Wed, 01 Jun 2011 16:41:21 -0700 [thread overview]
Message-ID: <87ei3dxgpq.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1306619520-25730-8-git-send-email-jrollins@finestructure.net>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Sat, 28 May 2011 14:51:42 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> The test in json was inferior to the one in search-output, since it
> wasn't properly testing for the presence of a trailing newline.
Hi Jamie,
I've pushed the series up to this point now, (along with the vim
improvements that weren't in your original mailing of the series).
I really appreciate the missing-newline bug-fix along with all the
improved testing for that. Thanks! I re-ordered that portion of the
patch series a tiny bit to put the bug fix immediately after the commit
that makes the tests start failing. I also reworded a few commit
messages slightly.
But I didn't make any code changes so it's trivial enough for me to keep
using "git rebase" to keep your series on top of my modified master.
I'll keep posting as I'm pushing.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-06-01 23:41 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 21:51 release-candidate/0.6 redux Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 01/25] fix check for libdir in ldconfig paths Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 02/25] add note about updating the debian symbols file to the RELEASE file Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 03/25] test: modify search-output test to use the new test_expect_equal_file function Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 04/25] test: move "Search for non-existent message prints nothing" to search-output, and add similar test for format=json Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 05/25] fix trailing newlines in notmuch search Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 06/25] test: move utf-8 subject search test from json to search test script Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 07/25] test: remove json test for search null result, since it's being more properly tested in search-output Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 08/25] create and set temporary home directory Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 09/25] emacs: Define several faces for the crypto-status button Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 10/25] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 11/25] test: add test for sanitized notmuch-search output Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 12/25] test: cleanup search-output test names (no functional change) Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 13/25] emacs: Use "message-cited-text" instead of "message-cited-text-face" Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 15/25] Use message-field-value instead of message-fetch-field in FCC header setup Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 16/25] lib/message-file: plug three memleaks Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 17/25] avoid segfault when calling sanitize_string() on NULL Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 18/25] Fix search output sanitization test Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 19/25] emacs: fix notmuch-show-part-button to not include newline Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 20/25] emacs: Don't always prompt for the "From" address when replying Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 21/25] emacs: Cleaner interface when prompting for sender address Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 22/25] test: fix test_expect_equal_file test to copy instead of mv test files Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 23/25] test: update emacs test to use test_expect_equal_file Jameson Graef Rollins
2011-05-28 21:51 ` [PATCH 24/25] test: modify multipart " Jameson Graef Rollins
2011-05-28 21:52 ` [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text Jameson Graef Rollins
2011-06-03 19:56 ` Carl Worth
2011-06-03 21:26 ` Jameson Graef Rollins
2011-06-03 22:38 ` Carl Worth
2011-06-03 22:57 ` Jameson Graef Rollins
2011-06-03 21:39 ` Jameson Graef Rollins
2011-06-03 19:24 ` [PATCH 17/25] avoid segfault when calling sanitize_string() on NULL Carl Worth
2011-06-02 5:10 ` [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check Carl Worth
2011-06-02 6:49 ` Dmitry Kurochkin
2011-06-03 20:05 ` Carl Worth
2011-06-03 20:22 ` Dmitry Kurochkin
2011-06-03 21:03 ` Carl Worth
2011-06-23 22:22 ` Carl Worth
2011-06-23 22:58 ` Dmitry Kurochkin
2011-06-23 23:24 ` Carl Worth
2011-06-01 23:41 ` Carl Worth [this message]
2011-06-01 23:22 ` [PATCH 01/25] fix check for libdir in ldconfig paths Carl Worth
2011-06-01 23:27 ` Jameson Graef Rollins
2011-05-28 21:58 ` release-candidate/0.6 redux Jameson Graef Rollins
2011-05-29 2:49 ` Austin Clements
2011-05-31 18:43 ` Jameson Graef Rollins
2011-06-04 1:27 ` Carl Worth
2011-06-06 0:35 ` Jameson Graef Rollins
2011-06-06 12:17 ` Carl Worth
2011-06-06 16:28 ` tag sharing [was: Re: release-candidate/0.6 redux] Jameson Graef Rollins
2011-06-06 17:20 ` Jesse Rosenthal
2011-06-08 17:46 ` Jameson Graef Rollins
2011-06-08 19:18 ` Jesse Rosenthal
2011-10-06 12:56 ` tag sharing David Bremner
2011-10-06 13:21 ` Jesse Rosenthal
2011-10-06 14:18 ` David Bremner
2011-10-06 19:49 ` Jesse Rosenthal
2011-10-06 20:23 ` David Bremner
2011-10-06 20:40 ` Jesse Rosenthal
2011-10-07 0:10 ` David Bremner
2011-10-07 11:36 ` Jesse Rosenthal
2011-10-07 12:01 ` Jesse Rosenthal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei3dxgpq.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).