unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] test: remove useless test_emacs call from an emacs FCC test
@ 2011-06-23 23:59 Dmitry Kurochkin
  2011-06-24  0:12 ` Carl Worth
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Kurochkin @ 2011-06-23 23:59 UTC (permalink / raw)
  To: notmuch

---
 test/emacs |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/test/emacs b/test/emacs
index 9b5d485..6f82b08 100755
--- a/test/emacs
+++ b/test/emacs
@@ -124,7 +124,6 @@ mkdir -p mail/sent-string/new
 mkdir -p mail/sent-string/tmp
 
 test_begin_subtest "notmuch-fcc-dirs set to a string"
-test_emacs "(setq notmuch-fcc-dirs nil) (notmuch-mua-mail) (princ (buffer-string))" > OUTPUT
 test_emacs "(setq notmuch-fcc-dirs \"sent-string\") (notmuch-mua-mail) (princ (buffer-string))" > OUTPUT
 cat <<EOF >EXPECTED
 From: Notmuch Test Suite <test_suite@notmuchmail.org>
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] test: remove useless test_emacs call from an emacs FCC test
  2011-06-23 23:59 [PATCH] test: remove useless test_emacs call from an emacs FCC test Dmitry Kurochkin
@ 2011-06-24  0:12 ` Carl Worth
  2011-06-24  1:15   ` David Bremner
  0 siblings, 1 reply; 4+ messages in thread
From: Carl Worth @ 2011-06-24  0:12 UTC (permalink / raw)
  To: Dmitry Kurochkin, notmuch

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

On Fri, 24 Jun 2011 03:59:33 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> ---
>  test/emacs |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Thanks for the catch. That was left over from some debugging I was doing
while writing the patch originally.

All fixed.

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] test: remove useless test_emacs call from an emacs FCC test
  2011-06-24  0:12 ` Carl Worth
@ 2011-06-24  1:15   ` David Bremner
  2011-06-26 14:22     ` Pieter Praet
  0 siblings, 1 reply; 4+ messages in thread
From: David Bremner @ 2011-06-24  1:15 UTC (permalink / raw)
  To: Carl Worth, Dmitry Kurochkin, notmuch

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

On Thu, 23 Jun 2011 17:12:04 -0700, Carl Worth <cworth@cworth.org> wrote:
> 
> Thanks for the catch. That was left over from some debugging I was doing
> while writing the patch originally.

I cherry-picked all three of these into the release branch.  I'm going
to skip the typo fixes for 0.6, unless convinced otherwise.

d

P.S. It would be great if people built the release branch and reported
any (new) problems.

[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] test: remove useless test_emacs call from an emacs FCC test
  2011-06-24  1:15   ` David Bremner
@ 2011-06-26 14:22     ` Pieter Praet
  0 siblings, 0 replies; 4+ messages in thread
From: Pieter Praet @ 2011-06-26 14:22 UTC (permalink / raw)
  To: David Bremner, Carl Worth, Dmitry Kurochkin, notmuch

On Thu, 23 Jun 2011 22:15:25 -0300, David Bremner <david@tethera.net> wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
> [...] I'm going
> to skip the typo fixes for 0.6, unless convinced otherwise.

Well, the whole point of my de-typo-ifying sprint was to make 0.6 a
~typo-free release, actually :D

But... I'll be the first to admit that it bears no importance whatsoever
regarding actual day-to-day usage of Notmuch, so either way, I don't mind.

> d
> 
> P.S. It would be great if people built the release branch and reported
> any (new) problems.
Non-text part: application/pgp-signature
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch


Peace

-- 
Pieter


[1] id:"1307202852-4398-1-git-send-email-pieter@praet.org"

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-06-26 14:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-23 23:59 [PATCH] test: remove useless test_emacs call from an emacs FCC test Dmitry Kurochkin
2011-06-24  0:12 ` Carl Worth
2011-06-24  1:15   ` David Bremner
2011-06-26 14:22     ` Pieter Praet

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).