unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* Missing inlined message/rfc822 bodies?
@ 2011-07-18  8:06 Keith Packard
  2011-07-18 11:56 ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Keith Packard @ 2011-07-18  8:06 UTC (permalink / raw)
  To: notmuch

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]


I wasn't seeing anything for an inlined message/rfc822 part (as with a
forwarded email message) and discovered that for some reason, the
message structure wasn't as expected. The following patch appears to
help me.

I'm still stuck trying to use the 'v' key to display attachments from
forwarded messages; it looks like mm-dissect-buffer isn't digging into
the attached message and pulling the embedded attachments out or something.

However, I can at least view the message and save the attachments now.

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..402fb2c 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -519,6 +519,12 @@ current buffer, if possible."
     ;; message display.
     (insert "\n")
 
+    ;;
+    ;; I dunno, sometimes the message part is a single element list containing the plist
+    ;;
+    (if (not inner-parts)
+      (setq inner-parts (plist-get (car message-part) :content)))
+
     ;; Show all of the parts.
     (mapc (lambda (inner-part)
 	    (notmuch-show-insert-bodypart msg inner-part depth))


-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: Missing inlined message/rfc822 bodies?
  2011-07-18  8:06 Missing inlined message/rfc822 bodies? Keith Packard
@ 2011-07-18 11:56 ` David Bremner
  2011-07-18 16:00   ` Keith Packard
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2011-07-18 11:56 UTC (permalink / raw)
  To: Keith Packard, notmuch

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Mon, 18 Jul 2011 01:06:05 -0700, "Keith Packard" <keithp@keithp.com> wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
> 
> I wasn't seeing anything for an inlined message/rfc822 part (as with a
> forwarded email message) and discovered that for some reason, the
> message structure wasn't as expected. The following patch appears to
> help me.

Hi Keith;

Did you have a chance to try jrollins' patches

    id:"1307320169-29905-1-git-send-email-jrollins@finestructure.net"

I'm curious if you're both solving the same problem.

d

[-- Attachment #2: Type: application/pgp-signature, Size: 315 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Missing inlined message/rfc822 bodies?
  2011-07-18 11:56 ` David Bremner
@ 2011-07-18 16:00   ` Keith Packard
  0 siblings, 0 replies; 3+ messages in thread
From: Keith Packard @ 2011-07-18 16:00 UTC (permalink / raw)
  To: David Bremner, notmuch

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On Mon, 18 Jul 2011 08:56:13 -0300, David Bremner <david@tethera.net> wrote:

> I'm curious if you're both solving the same problem.

I would assume so; my patch simply kludges around the problem with a
hack in the emacs code while jrollins is fixing the underlying gmime
interactions.

-- 
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-18 16:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-18  8:06 Missing inlined message/rfc822 bodies? Keith Packard
2011-07-18 11:56 ` David Bremner
2011-07-18 16:00   ` Keith Packard

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).