[PATCH] notmuch.vim: fix application of tags when advancing

[PATCH] notmuch.vim: fix application of tags when advancing

[David Riebenbauer]

When advancing to the next thread, advance tags would be removed
instead of added.
---
 vim/plugin/notmuch.vim |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/vim/plugin/notmuch.vim b/vim/plugin/notmuch.vim
index 21985c7..f0bc416 100644
--- a/vim/plugin/notmuch.vim
+++ b/vim/plugin/notmuch.vim
@@ -616,7 +616,7 @@ function! s:NM_show_advance_marking_read_and_archiving()
                         " do this last to hide the latency
                         let filter = <SID>NM_combine_tags('tag:', advance_tags, 'OR', '()')
                                  \ + ['AND', msg_top['id']]
-                        call map(advance_tags, '"-" . v:val')
+                        call map(advance_tags, '"+" . v:val')
                         call <SID>NM_tag(filter, advance_tags)
                 endif
                 return
-- 
1.7.2.5

Re: [PATCH] notmuch.vim: fix application of tags when advancing

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Fri, 21 Oct 2011 20:16:21 +0200, David Riebenbauer <davrieb@liegesta.at> wrote:
> When advancing to the next thread, advance tags would be removed
> instead of added.

Hi, David.  I'm not a vim user but this patch appears to be changing the
sense of a tagging operation, which I imagine might severely change the
interface experience.  Are you sure this is what you want?  I guess I'll
leave it to other vim users to comment.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH] notmuch.vim: fix application of tags when advancing

[David Riebenbauer]

* David Riebenbauer <davrieb@liegesta.at> [2011-10-21 20:16]:
> When advancing to the next thread, advance tags would be removed
> instead of added.

Actually forget that patch. When applied to current master it would
just reintroduce the bug, I was trying to fix.
Seems that in the meantime it was fixed in another way.

Sorry,
David

-- 
David Riebenbauer
Jabber: davrieb@jabber.ccc.de - ICQ: 322056002 
http://liegesta.at