From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 43109429E21 for ; Wed, 26 Oct 2011 19:53:09 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DA0C3y28LYkQ for ; Wed, 26 Oct 2011 19:53:08 -0700 (PDT) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 576FE431FB6 for ; Wed, 26 Oct 2011 19:53:08 -0700 (PDT) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id CB23F3280B9; Wed, 26 Oct 2011 19:53:05 -0700 (PDT) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-136-149.socal.res.rr.com [76.174.136.149]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id C66A0328085; Wed, 26 Oct 2011 19:53:02 -0700 (PDT) Received: by finestructure.net (Postfix, from userid 1000) id 479DEAF1; Wed, 26 Oct 2011 19:53:02 -0700 (PDT) From: Jameson Graef Rollins To: Thomas Schwinge Subject: Re: [PATCH] emacs: Modify notmuch-show-get-message-id to return message-id unprefixed with "id:". In-Reply-To: <87ehykflzw.fsf@kepler.schwinge.homeip.net> References: <87mxdabyy8.fsf@washington.ligo-wa.caltech.edu> <1318199748-25058-1-git-send-email-jrollins@finestructure.net> <87ehykflzw.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9-24-g2fd0ca5 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Oct 2011 19:52:59 -0700 Message-ID: <87ehxzb0xg.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2011 02:53:09 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Tue, 11 Oct 2011 01:46:43 +0200, Thomas Schwinge = wrote: > On Sun, 9 Oct 2011 15:35:48 -0700, Jameson Graef Rollins wrote: > > (defun notmuch-show-get-message-id () > > "Return the message id of the current message." > > - (concat "id:\"" (notmuch-show-get-prop :id) "\"")) > > + (concat "\"" (notmuch-show-get-prop :id) "\"")) >=20 > Shouldn't the double quotes be removed here, too? (And be re-added in > the other places where id: is added.) In point of fact, do we need these quotes around message IDs at all? Can message IDs have characters that would need to be escaped for the shell? This seems to also be related to the issue brought up by Erlend Simonsen in [0], where emacs 24 seems to be shell-quoting things as needed. So maybe these quotes aren't actually needed at all?... jamie. [0] id:87y5w9w6dm.fsf@fudge.hue.no --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOqMeLAAoJEO00zqvie6q8tWUQAKEnU8sOxC83NpH3yWb9lbew om9QmqohxpjlrNC45HfevuVtTK1Esg3HLbAWxgKHc7m5Fmg8B4/3o5M+eTeMu14f O7s+tkViYBl3uKY6OMKSUhURvILKalfwlUAI27H+GNGN3e5gUP4+qf6rLeqWf+Py e0d7J3meCpxTVoNxsigKBoCcS7pmXxDO3uanbtjPOpoAZIDTNePlwRuatv+OGTYw V1krGO3JEztSijfSeNNZKLgIOqnzb5n28jlVeirDc5bWZW1KBaymgpMTYKndupir C1mJWC+OTwWS0/LRsPIzdWRjP1sWegqwJ/+WYq90Wue7d+469KVki5NnWx/vmoz8 8Cp7neiU1s2Ep2fGoY5Wuxhuh4RDD+g2bgYNXrGBsKH7YUsq2zND53I9e/NJRZOc hrIjiGVZajPi73EF0qPeBXAv4gGk2l3jVoUeGjix6OLo8h3KcXkZJAsEue54XCNr mXOfauHhZEWK5ulgc5ok0Pwan+7C8QovDsjqCiubNeQhFiTYZnhCEGFuXyHQxe7T zT220pVAP0PeKBYDeaFkzeRJzcno1P5rqAoLGQimuSmF2XfcbM5sy+Rw73XlV7lz QWap6+bYlYXN4+ds1c5oOQidHzAOEzTWanX6fSGyvQsZshEMRMUJLasurDglan6f dfT4PlsrE505nARySbny =RNOs -----END PGP SIGNATURE----- --=-=-=--