From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id D1AB6429E25 for ; Tue, 1 Nov 2011 12:55:37 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MG5X2ccrCGhQ for ; Tue, 1 Nov 2011 12:55:37 -0700 (PDT) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C76AC431FB6 for ; Tue, 1 Nov 2011 12:55:36 -0700 (PDT) Received: by wwe6 with SMTP id 6so2311809wwe.2 for ; Tue, 01 Nov 2011 12:55:35 -0700 (PDT) Received: by 10.216.229.94 with SMTP id g72mr4951117weq.74.1320177333223; Tue, 01 Nov 2011 12:55:33 -0700 (PDT) Received: from localhost ([109.131.187.47]) by mx.google.com with ESMTPS id ff6sm81724wbb.10.2011.11.01.12.55.31 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 01 Nov 2011 12:55:32 -0700 (PDT) From: Pieter Praet To: Thomas Jost , notmuch@notmuchmail.org Subject: Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests In-Reply-To: <1317660447-27520-1-git-send-email-schnouki@schnouki.net> References: <871uuuywtt.fsf@convex-new.cs.unb.ca> <1317660447-27520-1-git-send-email-schnouki@schnouki.net> User-Agent: Notmuch/0.9+33~gadde72d (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Tue, 01 Nov 2011 20:54:49 +0100 Message-ID: <87ehxrvcs6.fsf@praet.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2011 19:55:38 -0000 On Mon, 3 Oct 2011 18:47:14 +0200, Thomas Jost wrote: > Here it is: a rebased version of Pieter's patch series adding prereqs for the > emacs and crypto tests [1], and Dmitry's patches for running emacs inside screen > in the test suite [2]. (Please note that this one also includes fixes to improve > hidden signatures handling in notmuch-show-advance-and-archive.) > I'm pleased to see these patches haven't moved to binary oblivion yet! > I had to do several changes to the original patches: > - prereqs are not tested using test_expect_success as they were in Pieter's > original patches, but using a new function called test_set_bin_prereq. I wrote > this before the gdb prereq was added, hence the different way to set it. > Indeed preferrable to using `test_expect_success' due to no longer overzealously reporting missing prereqs as failures, as well as getting rid of some duplication; This should also be used in the atomicity tests. > - some fixes in Pieter's patches so that it actually works when gpg is not > installed. Can't exactly remember what (...but you can just check his original > patches), but in the end it was working fine in a chroot without gpg. > Correct. I only added prereqs to actual tests (i.e. calls to `test_expect_success', `test_expect_equal', and `test_expect_equal_file'), while they should also have been added to both the `add_gnupg_home' function and the initialization of ${FINGERPRINT}. > - I added a little patch to smtp-dummy that makes the test suite work again in > Emacs 24 (tested with emacs-pretest 24.0.90). > > Here are the results when running the test suite on my computer: > - without GNU Screen: > All 247 tests behaved as expected (1 expected failure). > 46 tests skipped. > - with GNU Screen: > 242/247 tests passed. > 2 broken tests failed as expected. > 3 tests failed. > > (The 3 failed tests come from some trouble with Emacs 24, I'll try to fix this > later.) > > *Many* thanks to Dmitry Kurochkin and Pieter Praet for their work! > Thanks to you as well! All this duplication of effort is a real shame though. I'd also have preferred your fixes being in separate commits. I'll be commenting on these modified commits where needed, and have re-submitted my original series (rebased to current master) in a new thread [1]. > Regards, > Thomas > > [1] id:"1307016220-17509-1-git-send-email-pieter@praet.org" > [2] id:"1309496122-4965-1-git-send-email-dmitry.kurochkin@gmail.com" > > Dmitry Kurochkin (7): > test: run emacs inside screen > test: avoid using screen(1) configuration files > test: do not set frame width in emacs > test: `notmuch-show-advance-and-archive' with invisible signature > emacs: improve hidden signatures handling in > notmuch-show-advance-and-archive > emacs: remove no longer used functions from notmuch-show.el > emacs: remove unused `point-invisible-p' function > > Pieter Praet (4): > test: add 'GnuPG' prereq to dependent 'crypto' tests > test: add 'Emacs' prereq to dependent 'crypto' tests > test: add 'Emacs' prereq to dependent 'emacs' tests > test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' > tests > > Thomas Jost (2): > test: define a helper function for defining prereqs on executables > test: make smtp-dummy work with Emacs 24 > > emacs/notmuch-lib.el | 15 ------- > emacs/notmuch-show.el | 25 ++++------- > test/crypto | 46 ++++++++++++++------- > test/emacs | 85 ++++++++++++++++++++++++--------------- > test/emacs-large-search-buffer | 9 +++- > test/smtp-dummy.c | 2 +- > test/test-lib.el | 3 - > test/test-lib.sh | 31 +++++++++++++-- > 8 files changed, 127 insertions(+), 89 deletions(-) > > -- > 1.7.6.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Peace -- Pieter [1] id:"1320176954-4897-1-git-send-email-pieter@praet.org"