From: Jameson Graef Rollins <jrollins@finestructure.net>
To: David Bremner <david@tethera.net>,
Daniel Schoepe <daniel@schoepe.org>,
notmuch@notmuchmail.org
Subject: Re: Patch review/application process
Date: Tue, 01 Nov 2011 14:27:53 -0700 [thread overview]
Message-ID: <87ehxr4jom.fsf@servo.finestructure.net> (raw)
In-Reply-To: <87vcr3ehyg.fsf@convex-new.cs.unb.ca>
[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]
On Tue, 01 Nov 2011 16:55:03 -0300, David Bremner <david@tethera.net> wrote:
> One thing I think we need to clarify a bit is are we tagging whole
> threads or individual messages in the database. Because of the way
> notmuch search works, I had been tagging whole threads with
> notmuch::pushed (effectively to "mute" them) in the search
>
> notmuch search tag:notmuch::patch and \
> not tag:notmuch::pushed
>
> This is a bit aesthetically unappealing, anad every time someone replies
> to a thread it is effectively unmuted.
I have to say that I am very much against tagging threads with tags that
are really only applicable to specific messages, ie. ::patch, ::pushed
(I prefer ::applied, but whatever), etc. For instance, a thread maybe
contain multiple patches, but it is not itself a patch. Tagging entire
threads as ::patch means you can't do something like this:
notmuch show --format=mbox tag:notmuch::patch and not tag:notmuch::applied | git am
which would in my opinion be a shame.
> Since we don't have thread tagging yet (where e.g. tags are
> automagically applied to new messages I was thinking it might work have
> a tag like "notmuch::todo" and something like the following workflow
> (for patches)
I'm not sure why this is needed, since it seems to me that the whole
argument for tagging entire threads is that the individual messages are
*not* distinguishable from the thread.
> initially tag +notmuch::patch +notmuch::todo
>
> then when we "dispose" of the patch somehow, remove the notmuch::todo tag and
> replace with
> notmuch::pushed
> notmuch::obsolete
> or...
Please do *not* remove the ::patch tag. There is really no reason to.
The message still contain a patch whether or not it is applied
upstream. I really think this is important. The addition of something
From a set of "resolution" tags (::pushed, ::applied, ::obsolete,
::rejected, etc.) should indicate resolution of the issue.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2011-11-01 21:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 20:42 Patch review/application process Daniel Schoepe
2011-10-25 23:16 ` David Bremner
2011-10-26 18:29 ` Jani Nikula
2011-10-26 18:55 ` Daniel Schoepe
2011-11-01 14:28 ` David Bremner
2011-11-01 15:55 ` Jameson Graef Rollins
2011-11-01 19:55 ` David Bremner
2011-11-01 21:27 ` Jameson Graef Rollins [this message]
2011-11-01 23:22 ` David Bremner
2011-11-01 23:43 ` Jameson Graef Rollins
2011-11-02 15:49 ` Philip Hands
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehxr4jom.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=daniel@schoepe.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).