[PATCH] test: Add a test script for "notmuch tag"

[PATCH] test: Add a test script for "notmuch tag"

[Austin Clements]

---
This is, in principle, unrelated to the notmuch tag optimization I
just sent out, though it does test some things that would be weird
(though valid) to test if it weren't for that optimization.

 test/notmuch-test |    1 +
 test/tagging      |   41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 0 deletions(-)
 create mode 100755 test/tagging

diff --git a/test/notmuch-test b/test/notmuch-test
index 738f8f6..bbabf28 100755
--- a/test/notmuch-test
+++ b/test/notmuch-test
@@ -24,6 +24,7 @@ TESTS="
   search-by-folder
   search-position-overlap-bug
   search-insufficient-from-quoting
+  tagging
   json
   multipart
   thread-naming
diff --git a/test/tagging b/test/tagging
new file mode 100755
index 0000000..77202bf
--- /dev/null
+++ b/test/tagging
@@ -0,0 +1,41 @@
+#!/usr/bin/env bash
+test_description='"notmuch tag"'
+. ./test-lib.sh
+
+add_message '[subject]=One'
+add_message '[subject]=Two'
+
+test_begin_subtest "Adding tags"
+notmuch tag +tag1 +tag2 +tag3 \*
+output=$(notmuch search \* | notmuch_search_sanitize)
+test_expect_equal "$output" "\
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 tag2 tag3 unread)
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag1 tag2 tag3 unread)"
+
+test_begin_subtest "Removing tags"
+notmuch tag -tag1 -tag2 \*
+output=$(notmuch search \* | notmuch_search_sanitize)
+test_expect_equal "$output" "\
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag3 unread)
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag3 unread)"
+
+test_expect_code 1 "No tag operations" 'notmuch tag One'
+test_expect_code 1 "No query" 'notmuch tag +tag2'
+
+test_begin_subtest "Redundant tagging"
+notmuch tag +tag1 -tag3 One
+notmuch tag +tag1 -tag3 \*
+output=$(notmuch search \* | notmuch_search_sanitize)
+test_expect_equal "$output" "\
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; One (inbox tag1 unread)
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag1 unread)"
+
+test_begin_subtest "Special characters in tags"
+notmuch tag +':" ' \*
+notmuch tag -':" ' Two
+output=$(notmuch search \* | notmuch_search_sanitize)
+test_expect_equal "$output" "\
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; One (:\"  inbox tag1 unread)
+thread:XXX   2001-01-05 [1/1] Notmuch Test Suite; Two (inbox tag1 unread)"
+
+test_done
-- 
1.7.7.1

Re: [PATCH] test: Add a test script for "notmuch tag"

[Jameson Graef Rollins]

This seems like a pretty obviously important set of tests that was
missing.  Thanks, Austin.

jamie.

Re: [PATCH] test: Add a test script for "notmuch tag"

[David Bremner]

On Mon,  7 Nov 2011 22:57:11 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> ---
> This is, in principle, unrelated to the notmuch tag optimization I
> just sent out, though it does test some things that would be weird
> (though valid) to test if it weren't for that optimization.

Pushed. I'm still holding out for more review on the tag optimization
itself.

d