on deleting messages

on deleting messages

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

Now that Austin's excellent tag exclusion patch set [0] has been pushed,
the question remains if we want to support any delete-handling key
bindings in emacs.

Based on the show-mode improvements I recently sent [1], the following
patch set implements thread and message delete keys.

This is the last I'm going to comment on this issue.  If we don't want
to support this, we should put together something on the wiki that
states we don't want to support it and that users should just bind it
themselves (with a nice explanation how), so that we can try to reduce
the number of future patches on the issue.

Given the number of patches we've had on this issue, though, it's clear
that a lot of people expect this functionality, so we may want to
seriously consider supporting it.  Given Austin's tag exclusion stuff,
and the fact that "deleted" tags are excluded by default, we now have
the functionality that Carl originally wanted to see, so it's not so
unreasonable to support this functionality anymore.

jamie.

[0] id:"1326496024-14403-1-git-send-email-amdragon@mit.edu"
[1] id:"871uqy19yo.fsf@servo.finestructure.net"

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

[PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Jameson Graef Rollins]

No functional change here.  The help message previously referred to
the "delete" tag, but "deleted" is now preferred, so hopefully this
will reduce any potential confusion.
---
 emacs/notmuch.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index e4bca51..67ecd3a 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -660,12 +660,12 @@ This function advances the next thread when finished."
 Here is an example of how to color search results based on tags.
  (the following text would be placed in your ~/.emacs file):
 
- (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
+ (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
 						  :background \"blue\"))
                                    (\"unread\" . (:foreground \"green\"))))
 
 The attributes defined for matching tags are merged, with later
-attributes overriding earlier. A message having both \"delete\"
+attributes overriding earlier. A message having both \"deleted\"
 and \"unread\" tags with the above settings would have a green
 foreground and blue background."
   :type '(alist :key-type (string) :value-type (custom-face-edit))
-- 
1.7.7.3

[PATCH 2/3] emacs: message/thread deletion by adding "deleted" tag

[Jameson Graef Rollins]

---
 emacs/notmuch-show.el |   46 ++++++++++++++++++++++++++++++++++++++++++++++
 emacs/notmuch.el      |    8 ++++++++
 2 files changed, 54 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index c1d721e..141241d 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1506,6 +1506,52 @@ removed)."
   (notmuch-show-archive-message)
   (notmuch-show-next-open-message t))
 
+(defun notmuch-show-delete-thread (&optional undelete)
+  "Delete each message in thread.
+
+Delete each message currently shown by adding the \"deleted\" tag
+to each.  If a prefix argument is given, the messages will be
+\"undeleted\" (ie. the \"deleted\" tag will be removed instead of
+added).
+
+Note: This command is safe from any race condition of new messages
+being delivered to the same thread. It does not archive the
+entire thread, but only the messages shown in the current
+buffer."
+  (interactive)
+  (if undelete
+      (notmuch-show-remove-tag-thread "deleted")
+    (notmuch-show-add-tag-thread "deleted")))
+
+(defun notmuch-show-delete-thread-then-next ()
+  "Delete each message in thread, then show next thread from search."
+  (interactive)
+  (notmuch-show-delete-thread)
+  (notmuch-show-next-thread t))
+
+(defun notmuch-show-delete-thread-then-exit ()
+  "Delete each message in thread, then exit back to search results."
+  (interactive)
+  (notmuch-show-delete-thread)
+  (notmuch-show-next-thread))
+
+(defun notmuch-show-delete-message (&optional undelete)
+  "Delete the current message (add \"deleted\" tag).
+
+If a prefix argument is given, the message will be
+\"undeleted\" (ie. the \"deleted\" tag will be removed instead of
+added)."
+  (interactive)
+  (if undelete
+      (notmuch-show-remove-tag "deleted")
+    (notmuch-show-add-tag "deleted")))
+
+(defun notmuch-show-delete-message-then-next ()
+  "Archive the current message, then show next thread from search."
+  (interactive)
+  (notmuch-show-delete-message)
+  (notmuch-show-next-open-message t))
+
 (defun notmuch-show-stash-cc ()
   "Copy CC field of current message to kill-ring."
   (interactive)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 67ecd3a..2acb31b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -619,6 +619,14 @@ This function advances the next thread when finished."
   (notmuch-search-remove-tag-thread "inbox")
   (notmuch-search-next-thread))
 
+(defun notmuch-search-delete-thread ()
+  "Delete the currently selected thread (add \"deleted\" tag).
+
+This function advances the next thread when finished."
+  (interactive)
+  (notmuch-search-add-tag-thread "deleted")
+  (notmuch-search-next-thread))
+
 (defvar notmuch-search-process-filter-data nil
   "Data that has not yet been processed.")
 (make-variable-buffer-local 'notmuch-search-process-filter-data)
-- 
1.7.7.3

[PATCH 3/3] emacs: add delete key bindings for search and show mode.

[Jameson Graef Rollins]

This mimics the archiving keys ('a' and 'A').
---
 emacs/notmuch-show.el |    2 ++
 emacs/notmuch.el      |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 141241d..f0259d5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -945,6 +945,8 @@ thread id.  If a prefix is given, crypto processing is toggled."
 	(define-key map "-" 'notmuch-show-remove-tag)
 	(define-key map "+" 'notmuch-show-add-tag)
 	(define-key map "x" 'notmuch-show-archive-thread-then-exit)
+	(define-key map "d" 'notmuch-show-delete-message-then-next)
+	(define-key map "D" 'notmuch-show-delete-thread-then-next)
 	(define-key map "a" 'notmuch-show-archive-message-then-next)
 	(define-key map "A" 'notmuch-show-archive-thread-then-next)
 	(define-key map "N" 'notmuch-show-next-message)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 2acb31b..9f1b1ca 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -225,6 +225,7 @@ For a mouse binding, return nil."
     (define-key map "f" 'notmuch-search-filter)
     (define-key map [mouse-1] 'notmuch-search-show-thread)
     (define-key map "*" 'notmuch-search-operate-all)
+    (define-key map "d" 'notmuch-search-delete-thread)
     (define-key map "a" 'notmuch-search-archive-thread)
     (define-key map "-" 'notmuch-search-remove-tag)
     (define-key map "+" 'notmuch-search-add-tag)
-- 
1.7.7.3

Re: on deleting messages

[Jani Nikula]

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> Now that Austin's excellent tag exclusion patch set [0] has been pushed,
> the question remains if we want to support any delete-handling key
> bindings in emacs.
> 
> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.
> 
> Given the number of patches we've had on this issue, though, it's clear
> that a lot of people expect this functionality, so we may want to
> seriously consider supporting it.  Given Austin's tag exclusion stuff,
> and the fact that "deleted" tags are excluded by default, we now have
> the functionality that Carl originally wanted to see, so it's not so
> unreasonable to support this functionality anymore.

I think it's reasonable to consider having key bindings (or other
special handling) for pretty much *any* tags that are special to
notmuch: inbox, unread, draft, flagged, etc. (An exhaustive list should
be documented somewhere.)

Looking at the source and history, I have to admit there has been
intent, and code, to have support for "deleted" tag. See for example
TODO or [1].

And I agree there has been demand for this.

I say let's have this.

But make it clear that "deleted" is just a tag; that the messages aren't
going away, not by notmuch anyway.


BR,
Jani.

[1] commit 2c262042ac174d7bc96d6035ab9c88bd0abe7f35

Re: on deleting messages

[Xavier Maillard]

Hi,

On Tue, 17 Jan 2012 11:01:45 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

[ ... ]

> Based on the show-mode improvements I recently sent [1], the following
> patch set implements thread and message delete keys.
> 
> This is the last I'm going to comment on this issue.  If we don't want
> to support this, we should put together something on the wiki that
> states we don't want to support it and that users should just bind it
> themselves (with a nice explanation how), so that we can try to reduce
> the number of future patches on the issue.

I think this is something every (new) users are expecting to have: a
simple and sensible way "to list the trashed messages". So I'd go for
it.

/Xavier

Re: on deleting messages

[Tomi Ollila]

On Tue, 17 Jan 2012 22:21:18 +0200, Jani Nikula <jani@nikula.org> wrote:
> Looking at the source and history, I have to admit there has been
> intent, and code, to have support for "deleted" tag. See for example
> TODO or [1].
> 
> And I agree there has been demand for this.
> 
> I say let's have this.

+1

> But make it clear that "deleted" is just a tag; that the messages aren't
> going away, not by notmuch anyway.

Indeed; notmuch does not touch the content of files nor touch the existence
of files.

Emacs tips wiki page may contain a section user can shoot thems^H^H^H^H^H^H^H^H^H^H^H
configure the actual file deleting functionality for themselves.

> BR,
> Jani.

Tomi

Re: on deleting messages

[Antoine Beaupré]

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

Hi Jamie!

I have taken the time to test those patches and those in the other
thread[1], and I like it! I was able to run all tests with the patches
applied and I am now running them alongside with most recent master
gd51b784 and Mark Walter's attachment buttons patch[2].

So I support those patches and hope they get in. The only issue I could
find was that I have the reflex of hitting A (capital a) instead of just
"a" in the search view because that's the key i hit in the show
view... but that's probably something i should get used to.

If something pops up I'll let you know!

A.

[1] id:"1325975294-646-2-git-send-email-jrollins@finestructure.net"
[2] id:"1326843886-18387-1-git-send-email-markwalters1009@gmail.com"

-- 
Antoine Beaupré +++ Réseau Koumbit Networks +++ +1.514.387.6262 #208
--------------------------------------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: on deleting messages

[David Edmondson]

[-- Attachment #1: Type: text/plain, Size: 111 bytes --]

Add the bindings. Provide documentation that makes it clear that they
just add tags and never delete anything.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Mark Walters]

On Tue, 17 Jan 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> No functional change here.  The help message previously referred to
> the "delete" tag, but "deleted" is now preferred, so hopefully this
> will reduce any potential confusion.

This patch is trivially correct regardless of the rest of the
series. 

I think the rest of the series (which provides keybindings for
adding/removing the delete tag to messages/threads) is worthwhile
particularly now the exclude stuff is fairly complete (feedback at the
time looked positive).

Patch 2/3 needs simple but genuine rebasing as the names of the
tagging functions have changed though. 

Best wishes

Mark

> ---
>  emacs/notmuch.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index e4bca51..67ecd3a 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -660,12 +660,12 @@ This function advances the next thread when finished."
>  Here is an example of how to color search results based on tags.
>   (the following text would be placed in your ~/.emacs file):
>  
> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>  						  :background \"blue\"))
>                                     (\"unread\" . (:foreground \"green\"))))
>  
>  The attributes defined for matching tags are merged, with later
> -attributes overriding earlier. A message having both \"delete\"
> +attributes overriding earlier. A message having both \"deleted\"
>  and \"unread\" tags with the above settings would have a green
>  foreground and blue background."
>    :type '(alist :key-type (string) :value-type (custom-face-edit))
> -- 
> 1.7.7.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Tomi Ollila]

On Sun, Apr 15 2012, Mark Walters wrote:

> On Tue, 17 Jan 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
>> No functional change here.  The help message previously referred to
>> the "delete" tag, but "deleted" is now preferred, so hopefully this
>> will reduce any potential confusion.
>
> This patch is trivially correct regardless of the rest of the
> series. 

Agreed. +1

>
> I think the rest of the series (which provides keybindings for
> adding/removing the delete tag to messages/threads) is worthwhile
> particularly now the exclude stuff is fairly complete (feedback at the
> time looked positive).
>
> Patch 2/3 needs simple but genuine rebasing as the names of the
> tagging functions have changed though. 

Why not :)

>
> Best wishes
>
> Mark

Tomi


>
>> ---
>>  emacs/notmuch.el |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index e4bca51..67ecd3a 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -660,12 +660,12 @@ This function advances the next thread when finished."
>>  Here is an example of how to color search results based on tags.
>>   (the following text would be placed in your ~/.emacs file):
>>  
>> - (setq notmuch-search-line-faces '((\"delete\" . (:foreground \"red\"
>> + (setq notmuch-search-line-faces '((\"deleted\" . (:foreground \"red\"
>>  						  :background \"blue\"))
>>                                     (\"unread\" . (:foreground \"green\"))))
>>  
>>  The attributes defined for matching tags are merged, with later
>> -attributes overriding earlier. A message having both \"delete\"
>> +attributes overriding earlier. A message having both \"deleted\"
>>  and \"unread\" tags with the above settings would have a green
>>  foreground and blue background."
>>    :type '(alist :key-type (string) :value-type (custom-face-edit))
>> -- 
>> 1.7.7.3
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Sun, Apr 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This patch is trivially correct regardless of the rest of the
> series. 
>
> I think the rest of the series (which provides keybindings for
> adding/removing the delete tag to messages/threads) is worthwhile
> particularly now the exclude stuff is fairly complete (feedback at the
> time looked positive).

Sorry, I wish I could have purged all of these series from the list.
After a very protracted discussion on the topic it was decided that
notmuch will not support any delete tagging operations.  Users who wish
to do so can add support on their own:

  id:"87sjgk2xzf.fsf@servo.finestructure.net"
  http://notmuchmail.org/excluding/  

I highly recommend *not* re-starting this discussion.  There is no
solution that will satisfy everyone.  Just let it be.  Move on.  Nothing
to see here.  These are not the tags you're looking for...

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Tomi Ollila]

On Sun, Apr 15 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> On Sun, Apr 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:
>> This patch is trivially correct regardless of the rest of the
>> series. 
>>
>> I think the rest of the series (which provides keybindings for
>> adding/removing the delete tag to messages/threads) is worthwhile
>> particularly now the exclude stuff is fairly complete (feedback at the
>> time looked positive).
>
> Sorry, I wish I could have purged all of these series from the list.
> After a very protracted discussion on the topic it was decided that
> notmuch will not support any delete tagging operations.  Users who wish
> to do so can add support on their own:
>
>   id:"87sjgk2xzf.fsf@servo.finestructure.net"
>   http://notmuchmail.org/excluding/  
>
> I highly recommend *not* re-starting this discussion.  There is no
> solution that will satisfy everyone.  Just let it be.  Move on.  Nothing
> to see here.  These are not the tags you're looking for...

id:"1326826969-23545-1-git-send-email-jrollins@finestructure.net"

Does just "delete" -> "deleted" change: the only question I have left
is that should that be left as is, this change made, or just drop
the "delete" coloring altogether ?

>
> jamie.

Tomi

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Jameson Graef Rollins]

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

On Sun, Apr 15 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> id:"1326826969-23545-1-git-send-email-jrollins@finestructure.net"
>
> Does just "delete" -> "deleted" change: the only question I have left
> is that should that be left as is, this change made, or just drop
> the "delete" coloring altogether ?

Sorry, yes, I suppose this patch should still be applied.  Excludes for
"deleted" are the default, I believe, so if we are going to refer to it
in documentation we should probably be consistent.

On Sun, Apr 15 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Sun, Apr 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:
>> I think the rest of the series (which provides keybindings for
>> adding/removing the delete tag to messages/threads) is worthwhile
>> particularly now the exclude stuff is fairly complete (feedback at the
>> time looked positive).
>
> Sorry, I wish I could have purged all of these series from the list.
> After a very protracted discussion on the topic it was decided that
> notmuch will not support any delete tagging operations.  Users who wish
> to do so can add support on their own:

I think my reaction here was a little strong.  I'm not remembering how I
got the impression that there was more opposition to adding delete
keybindings than there was support.  I suppose now that excludes work so
well one (not me) might consider revisiting the issue.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[Tomi Ollila]

On Mon, Apr 16 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> On Sun, Apr 15 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> id:"1326826969-23545-1-git-send-email-jrollins@finestructure.net"
>>
>> Does just "delete" -> "deleted" change: the only question I have left
>> is that should that be left as is, this change made, or just drop
>> the "delete" coloring altogether ?
>
> Sorry, yes, I suppose this patch should still be applied.  Excludes for
> "deleted" are the default, I believe, so if we are going to refer to it
> in documentation we should probably be consistent.

That said, the following change in nmbug repository

D    1326826969-23545-1-git-send-email-jrollins@finestructure.net needs-review
A    1326826969-23545-1-git-send-email-jrollins@finestructure.net trivial

pushed.

Tomi

>
> On Sun, Apr 15 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
>> On Sun, Apr 15 2012, Mark Walters <markwalters1009@gmail.com> wrote:
>>> I think the rest of the series (which provides keybindings for
>>> adding/removing the delete tag to messages/threads) is worthwhile
>>> particularly now the exclude stuff is fairly complete (feedback at the
>>> time looked positive).
>>
>> Sorry, I wish I could have purged all of these series from the list.
>> After a very protracted discussion on the topic it was decided that
>> notmuch will not support any delete tagging operations.  Users who wish
>> to do so can add support on their own:
>
> I think my reaction here was a little strong.  I'm not remembering how I
> got the impression that there was more opposition to adding delete
> keybindings than there was support.  I suppose now that excludes work so
> well one (not me) might consider revisiting the issue.
>
> jamie.
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name.

[David Bremner]

Jameson Graef Rollins <jrollins@finestructure.net> writes:

> No functional change here.  The help message previously referred to
> the "delete" tag, but "deleted" is now preferred, so hopefully this
> will reduce any potential confusion.

I pushed this one patch from the series.

d