From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/4] Add a --body option to notmuch show
Date: Mon, 23 Jul 2012 12:16:32 -0700 [thread overview]
Message-ID: <87eho270fj.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1343066259-22523-1-git-send-email-markwalters1009@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 910 bytes --]
On Mon, Jul 23 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Version 2 of this patch set (version 1 at
> id:"1343060241-18283-1-git-send-email-markwalters1009@gmail.com"). This
> corrects the errors Austin spotted in v1, and makes it explicit that
> --body=false and --part>0 are incompatible.
>
>
> Mark Walters (4):
> cli: add --body=true|false option to notmuch-show.c
> test: add tests for the new --body=true|false option
> man: update man page for the new --body=true|false option
> schemata: update for --body=true|false option
>
> devel/schemata | 2 +-
> man/man1/notmuch-show.1 | 16 ++++++++++++++++
> notmuch-client.h | 3 ++-
> notmuch-reply.c | 2 +-
> notmuch-show.c | 30 ++++++++++++++++++++++--------
> test/json | 9 +++++++++
> 6 files changed, 51 insertions(+), 11 deletions(-)
Untested, but LGTM.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2012-07-23 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 17:57 [PATCH v2 0/4] Add a --body option to notmuch show Mark Walters
2012-07-23 17:57 ` [PATCH v2 1/4] cli: add --body=true|false option to notmuch-show.c Mark Walters
2012-07-23 17:57 ` [PATCH v2 2/4] test: add tests for the new --body=true|false option Mark Walters
2012-07-23 17:57 ` [PATCH v2 3/4] man: update man page " Mark Walters
2012-07-23 17:57 ` [PATCH v2 4/4] schemata: update for " Mark Walters
2012-07-23 18:34 ` [PATCH v2 0/4] Add a --body option to notmuch show Austin Clements
2012-07-23 19:16 ` Jameson Graef Rollins [this message]
2012-07-24 16:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eho270fj.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).