From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DE22C431FB6 for ; Fri, 19 Oct 2012 17:30:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CN94arGVON8k for ; Fri, 19 Oct 2012 17:30:14 -0700 (PDT) Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 432E1431FAE for ; Fri, 19 Oct 2012 17:30:14 -0700 (PDT) Received: by mail-vb0-f53.google.com with SMTP id fc21so1179379vbb.26 for ; Fri, 19 Oct 2012 17:30:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=l9hgjL7sqwmZ1+FN4CccIU9rT4KcMO2LzZnU21CCJE8=; b=wsrm9dDYTFuDOr85Cf6A8FvZWwKhdla1mobjKl+oCBZ13lc7SDtZZOZ7VueRLoxTfB cnzY56ALioqIVZoRSwN//4o6nxrRjIHy3wmOs0b4aywnyiOg5ukuIUsahW2tABr9InZo QwGUIXdq5naIeXfvp2+DRrSivo0khA/CYiPth2o0P1zZJldZIXY0enBcA6AzfrIYI7do abEPXY12H+vlcHqUQWdw81+WD1byiZCmGRvu+mY43ZcM7cj7SOt6SOcDNiVRM2Qnc7kf AWFT369LPhVfZwHuD3LhrN5pBdMabZoF0lFUzA9GVN+BrBrM+kaiR1RSm50wDqHK1+Fm 11sw== Received: by 10.52.94.225 with SMTP id df1mr2983713vdb.114.1350693013510; Fri, 19 Oct 2012 17:30:13 -0700 (PDT) Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) by mx.google.com with ESMTPS id g5sm2800448vez.6.2012.10.19.17.30.11 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 17:30:11 -0700 (PDT) From: Ethan Glasser-Camp To: Mark Walters , Austin Clements Subject: Re: [PATCH v2 (Draft)] emacs: split async json parser into utility function In-Reply-To: <87k3xlyoek.fsf@qmul.ac.uk> References: <87k3xo85tv.fsf@qmul.ac.uk> <20120730013506.GF8502@mit.edu> <87obmxyokt.fsf@qmul.ac.uk> <87k3xlyoek.fsf@qmul.ac.uk> User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 19 Oct 2012 20:30:07 -0400 Message-ID: <87ehku6l4g.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2012 00:30:15 -0000 Mark Walters writes: > Split out the json parser into a utility function. > --- > > Most of this patch is code movement: but I don't see how to arrange the > patch to show that. Hi! This looks like a straightforward patch and if it will make notmuch-pick more efficient, I'm in favor. I tagged this patch moreinfo because David Bremner's suggestions that you expand on the docstrings for notmuch-json-parser and notmuch-json-state are good ideas. I'd also propose that you split this patch into two patches -- one that pulls out the variables and performs the renames, and the other which breaks out the code into its own function. This should make the code movement more obvious. I haven't started full-time work yet so if you would like me to do this, I can ;) Based on David Bremner's feedback that it might be a good idea to have a commit message that explains exactly what is code movement and isn't, here's my proposal for a commit message. Split out the json parser into a utility function. This patch breaks out a chunk of notmuch-search-process-filter, with the following changes: - notmuch-search-json-parser becomes notmuch-json-parser. - notmuch-search-parser-state becomes notmuch-json-state. We also rearrange the json-error case but are careful to always call error-function in the results buffer. Ethan