From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/5] Use Xapian query syntax for batch-tag dump/restore
Date: Wed, 26 Dec 2012 10:55:06 -0400 [thread overview]
Message-ID: <87ehicrhh1.fsf@zancas.localnet> (raw)
In-Reply-To: <1356493723-11085-1-git-send-email-amdragon@mit.edu>
Austin Clements <amdragon@MIT.EDU> writes:
> This obsoletes
>
> id:1356415076-5692-1-git-send-email-amdragon@mit.edu
>
> In addition to incorporating all of David's suggestions, this reworks
> the boolean term parsing so it only handles the subset of quoting
> syntax used by make_boolean_term (which also happens to be all that we
> described in the man page for the format). The diff from v1 is below.
Implementation wise this series now looks OK to me; I think the dequote
routine could be slightly clearer, but it's a bit subjective at this
point.
IMHO the real question is if we like (or can live with) the resulting UI
for batch tagging. Mark ( id:87ehid5h64.fsf@qmul.ac.uk ) brings up the
question of whether tags with newlines should be somehow supported in a
batch-tagging context. The other UI issue I'm aware of is the fact that
tags with spaces needed to be quoted in two different ways for tag
operations and for queries. A relatively smooth upgrade path would be
to support Xapian quoting for tag operations in the future.
d
prev parent reply other threads:[~2012-12-26 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-26 3:48 [PATCH v2 0/5] Use Xapian query syntax for batch-tag dump/restore Austin Clements
2012-12-26 3:48 ` [PATCH v2 1/5] util: Factor out boolean term quoting routine Austin Clements
2012-12-26 14:24 ` David Bremner
2012-12-26 3:48 ` [PATCH v2 2/5] util: Function to parse boolean term queries Austin Clements
2012-12-26 14:31 ` David Bremner
2012-12-26 3:48 ` [PATCH v2 3/5] dump: Disallow \n in message IDs Austin Clements
2012-12-26 3:48 ` [PATCH v2 4/5] dump/restore: Use Xapian queries for batch-tag format Austin Clements
2012-12-26 3:48 ` [PATCH v2 5/5] man: Update notmuch-dump(1) and notmuch-restore(1) Austin Clements
2012-12-26 14:55 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehicrhh1.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).