[PATCH 1/1] emacs: fixed (declare-function ...) definitions

[PATCH 1/1] emacs: fixed (declare-function ...) definitions

[Tomi Ollila]

Some (declare-function ...) definitions were drifted away from the
actual (defun ...)'s. To find the drifts and to verify changes
the following command line was used:

$ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
---
 emacs/notmuch-hello.el | 2 +-
 emacs/notmuch-show.el  | 1 -
 emacs/notmuch-wash.el  | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index cda79f1..c1c6f4b 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -26,7 +26,7 @@
 (require 'notmuch-lib)
 (require 'notmuch-mua)
 
-(declare-function notmuch-search "notmuch" (query &optional oldest-first target-thread target-line continuation))
+(declare-function notmuch-search "notmuch" (&optional query oldest-first target-thread target-line continuation))
 (declare-function notmuch-poll "notmuch" ())
 
 (defcustom notmuch-hello-recent-searches-max 10
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a4d2c12..face2a0 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -38,7 +38,6 @@
 (require 'notmuch-print)
 
 (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))
-(declare-function notmuch-fontify-headers "notmuch" nil)
 (declare-function notmuch-search-next-thread "notmuch" nil)
 (declare-function notmuch-search-show-thread "notmuch" nil)
 
diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
index 826b6f4..80c475c 100644
--- a/emacs/notmuch-wash.el
+++ b/emacs/notmuch-wash.el
@@ -23,7 +23,7 @@
 
 (require 'coolj)
 
-(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth))
+(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth &optional hide))
 
 ;;
 
-- 
1.8.0

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

[Mark Walters]

On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> Some (declare-function ...) definitions were drifted away from the
> actual (defun ...)'s. To find the drifts and to verify changes
> the following command line was used:
>
> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'

This patch looks good to me +1.

Is it worth making the above command into a test?

Best wishes

Mark


>  emacs/notmuch-hello.el | 2 +-
>  emacs/notmuch-show.el  | 1 -
>  emacs/notmuch-wash.el  | 2 +-
>  3 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index cda79f1..c1c6f4b 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -26,7 +26,7 @@
>  (require 'notmuch-lib)
>  (require 'notmuch-mua)
>  
> -(declare-function notmuch-search "notmuch" (query &optional oldest-first target-thread target-line continuation))
> +(declare-function notmuch-search "notmuch" (&optional query oldest-first target-thread target-line continuation))
>  (declare-function notmuch-poll "notmuch" ())
>  
>  (defcustom notmuch-hello-recent-searches-max 10
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index a4d2c12..face2a0 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -38,7 +38,6 @@
>  (require 'notmuch-print)
>  
>  (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))
> -(declare-function notmuch-fontify-headers "notmuch" nil)
>  (declare-function notmuch-search-next-thread "notmuch" nil)
>  (declare-function notmuch-search-show-thread "notmuch" nil)
>  
> diff --git a/emacs/notmuch-wash.el b/emacs/notmuch-wash.el
> index 826b6f4..80c475c 100644
> --- a/emacs/notmuch-wash.el
> +++ b/emacs/notmuch-wash.el
> @@ -23,7 +23,7 @@
>  
>  (require 'coolj)
>  
> -(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth))
> +(declare-function notmuch-show-insert-bodypart "notmuch-show" (msg part depth &optional hide))
>  
>  ;;
>  
> -- 
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> Some (declare-function ...) definitions were drifted away from the
>> actual (defun ...)'s. To find the drifts and to verify changes
>> the following command line was used:
>>
>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
>
> This patch looks good to me +1.
>
> Is it worth making the above command into a test?

Maybe a release check?

d

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

[Tomi Ollila]

On Sat, Apr 13 2013, David Bremner <david@tethera.net> wrote:

> Mark Walters <markwalters1009@gmail.com> writes:
>
>> On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>>> Some (declare-function ...) definitions were drifted away from the
>>> actual (defun ...)'s. To find the drifts and to verify changes
>>> the following command line was used:
>>>
>>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
>>
>> This patch looks good to me +1.
>>
>> Is it worth making the above command into a test?

I attempted to do a test -- failed miserably with test_emacs ()

> Maybe a release check?

You want to delegate the work developers should do to yourself
(if not fixing the things, moan about those ;)

For the time being I drop needs-review tag.

> d

Tomi

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Some (declare-function ...) definitions were drifted away from the
> actual (defun ...)'s. To find the drifts and to verify changes
> the following command line was used:
>
> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'

pushed,

d