From: Jani Nikula <jani@nikula.org>
To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
Subject: Re: Solaris support - missing or incompatible functions
Date: Sun, 12 May 2013 23:02:26 +0300 [thread overview]
Message-ID: <87ehdc9dbh.fsf@nikula.org> (raw)
In-Reply-To: <1367853362-11846-1-git-send-email-Vladimir.Marek@oracle.com>
On Mon, 06 May 2013, Vladimir.Marek@oracle.com wrote:
> I can't run the notmuch 'make test' on Solaris (too old bash) and on linux the
> results are
>
> 421/525 tests passed.
> 25 tests failed.
> 79 tests skipped.
>
> but they are the same without my changes too ...
The series LGTM, except I didn't pay much attention to the timegm()
implementation. I hope the time parsing tests pass though. If they do,
and you think the implementation is good enough, then who am I to
argue. ;)
BR,
Jani.
next prev parent reply other threads:[~2013-05-12 20:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 15:15 Solaris support - missing or incompatible functions Vladimir.Marek
2013-05-06 15:15 ` [PATCH 1/4] getpwuid: check for standards compliance (Solaris support) Vladimir.Marek
2013-05-06 15:16 ` [PATCH 2/4] asctime: " Vladimir.Marek
2013-05-06 15:16 ` [PATCH 3/4] strsep: check for availability " Vladimir.Marek
2013-05-06 15:16 ` [PATCH 4/4] timegm: add portable implementation " Vladimir.Marek
2013-05-12 20:02 ` Jani Nikula [this message]
2013-05-12 20:21 ` Solaris support - missing or incompatible functions Vladimir Marek
2013-05-12 20:45 ` Jani Nikula
2013-05-13 5:05 ` Vladimir Marek
2013-05-18 13:19 ` David Bremner
2013-05-20 9:48 ` Vladimir Marek
2013-05-20 11:10 ` Tomi Ollila
2013-05-20 13:19 ` Vladimir Marek
2013-08-16 12:05 ` Vladimir Marek
2013-08-16 12:32 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ehdc9dbh.fsf@nikula.org \
--to=jani@nikula.org \
--cc=Vladimir.Marek@oracle.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).