[RFC PATCH] emacs: Remove v command

[RFC PATCH] emacs: Remove v command

[Austin Clements]

This removes the v command, since we now have much nicer part commands,
and deprecates the underlying notmuch-show-view-all-mime-parts.  This
also means that people who try using the old unprefixed 'v' command on
a part button will no longer be greeted by ALL of their parts popping
up.
---
 emacs/notmuch-show.el |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 5771950..bae3171 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
   "Enable Visual Line mode."
   (visual-line-mode t))
 
+;; DEPRECATED in Notmuch 0.16 since we now have convenient part
+;; commands.  We'll keep the command around for a version or two in
+;; case people want to bind it themselves.
 (defun notmuch-show-view-all-mime-parts ()
   "Use external viewers to view all attachments from the current message."
   (interactive)
@@ -1216,7 +1219,6 @@ reset based on the original query."
 	(define-key map "|" 'notmuch-show-pipe-message)
 	(define-key map "w" 'notmuch-show-save-attachments)
 	(define-key map "V" 'notmuch-show-view-raw-message)
-	(define-key map "v" 'notmuch-show-view-all-mime-parts)
 	(define-key map "c" 'notmuch-show-stash-map)
 	(define-key map "=" 'notmuch-show-refresh-view)
 	(define-key map "h" 'notmuch-show-toggle-visibility-headers)
-- 
1.7.10.4

Re: [RFC PATCH] emacs: Remove v command

[Mark Walters]

I like the change. +1 from me.

Mark

Austin Clements <amdragon@MIT.EDU> writes:

> This removes the v command, since we now have much nicer part commands,
> and deprecates the underlying notmuch-show-view-all-mime-parts.  This
> also means that people who try using the old unprefixed 'v' command on
> a part button will no longer be greeted by ALL of their parts popping
> up.
> ---
>  emacs/notmuch-show.el |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 5771950..bae3171 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
>    "Enable Visual Line mode."
>    (visual-line-mode t))
>  
> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part
> +;; commands.  We'll keep the command around for a version or two in
> +;; case people want to bind it themselves.
>  (defun notmuch-show-view-all-mime-parts ()
>    "Use external viewers to view all attachments from the current message."
>    (interactive)
> @@ -1216,7 +1219,6 @@ reset based on the original query."
>  	(define-key map "|" 'notmuch-show-pipe-message)
>  	(define-key map "w" 'notmuch-show-save-attachments)
>  	(define-key map "V" 'notmuch-show-view-raw-message)
> -	(define-key map "v" 'notmuch-show-view-all-mime-parts)
>  	(define-key map "c" 'notmuch-show-stash-map)
>  	(define-key map "=" 'notmuch-show-refresh-view)
>  	(define-key map "h" 'notmuch-show-toggle-visibility-headers)
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [RFC PATCH] emacs: Remove v command

[Tomi Ollila]

On Mon, Jun 03 2013, Austin Clements <amdragon@MIT.EDU> wrote:

> This removes the v command, since we now have much nicer part commands,
> and deprecates the underlying notmuch-show-view-all-mime-parts.  This
> also means that people who try using the old unprefixed 'v' command on
> a part button will no longer be greeted by ALL of their parts popping
> up.
> ---

+1

Tomi


>  emacs/notmuch-show.el |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 5771950..bae3171 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
>    "Enable Visual Line mode."
>    (visual-line-mode t))
>  
> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part
> +;; commands.  We'll keep the command around for a version or two in
> +;; case people want to bind it themselves.
>  (defun notmuch-show-view-all-mime-parts ()
>    "Use external viewers to view all attachments from the current message."
>    (interactive)
> @@ -1216,7 +1219,6 @@ reset based on the original query."
>  	(define-key map "|" 'notmuch-show-pipe-message)
>  	(define-key map "w" 'notmuch-show-save-attachments)
>  	(define-key map "V" 'notmuch-show-view-raw-message)
> -	(define-key map "v" 'notmuch-show-view-all-mime-parts)
>  	(define-key map "c" 'notmuch-show-stash-map)
>  	(define-key map "=" 'notmuch-show-refresh-view)
>  	(define-key map "h" 'notmuch-show-toggle-visibility-headers)
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [RFC PATCH] emacs: Remove v command

[David Bremner]

Austin Clements <amdragon@MIT.EDU> writes:

> This removes the v command, since we now have much nicer part commands,
> and deprecates the underlying notmuch-show-view-all-mime-parts.  This
> also means that people who try using the old unprefixed 'v' command on
> a part button will no longer be greeted by ALL of their parts popping
> up.

pushed.

Let the complaints begin,

d