From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro
Date: Tue, 08 Dec 2015 08:44:10 -0400 [thread overview]
Message-ID: <87egexyusl.fsf@zancas.localnet> (raw)
In-Reply-To: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Some compilers (older than gcc 4.5 and clang 2.9) do support
> __attribute__ ((deprecated)) but not
> __attribute__ ((deprecated("message"))).
>
> Check (clang) and know (gcc) which versions support which variants
> and make two definitions of define NOTMUCH_DEPRECATED macro;
> one with and and one without the ("message") part.
>
> __has_extension() replacement was modeled after __has_attribute()
> definition in compat/function-attributes.h. Thanks Justus.
Hi Tomi;
I keep coming back to review this patch, but I'm blocked by the fact
that clang++ is broken on Debian (and lots of other places, I guess) for
months.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797038
d
next prev parent reply other threads:[~2015-12-08 12:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 14:37 [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro Tomi Ollila
2015-12-08 12:44 ` David Bremner [this message]
2015-12-08 13:15 ` Tomi Ollila
2015-12-29 11:52 ` Jani Nikula
2016-03-01 16:46 ` Justus Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egexyusl.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).