From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 5/6] Modify our local copy of message-do-fcc
Date: Sat, 03 Sep 2016 19:37:21 -0300 [thread overview]
Message-ID: <87eg50k3tq.fsf@zancas.localnet> (raw)
In-Reply-To: <87eg503bo3.fsf@qmul.ac.uk>
Mark Walters <markwalters1009@gmail.com> writes:
> Many thanks for the review.
>
> On Sat, 03 Sep 2016, David Bremner <david@tethera.net> wrote:
>> Mark Walters <markwalters1009@gmail.com> writes:
>>
>>> + (cons '("Newsgroups" . default)
>>> + rfc2047-header-encoding-alist)))
>> this seems like more message-mode functionality we don't need? I guess
>> it's harmless, but could omit one dynamically bound variable.
>
> I agree this might as well be removed.
>
>>> + (while list
>>> + (setq file (pop list))
>>> + (notmuch-fcc-handler file))
>>> + (kill-buffer (current-buffer)))))))
>>
>> Is it sensible for us to support a list of output destinations? It seems
>> like an odd corner case to me. I guess the amount of extra code is not
>> too high. In any case I suppose it could be a followup (as could my
>> comment above).
>
> We get a list here if someone has more than one fcc header. I don't know
> why they would want to, but gnus supported it so I kept it. I am happy
> either way here.
Hmm. OK. let's leave it as long as it doesn't cause any problems
d
next prev parent reply other threads:[~2016-09-03 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 23:02 [PATCH 0/6] Use notmuch insert for fcc Mark Walters
2016-06-10 23:02 ` [PATCH 1/6] emacs: notmuch-check-exit-status bugfix Mark Walters
2016-06-10 23:02 ` [PATCH 2/6] emacs: maildir-fcc: prepare for use of notmuch insert Mark Walters
2016-06-10 23:02 ` [PATCH 3/6] emacs: maildir import message-do-fcc Mark Walters
2016-06-10 23:02 ` [PATCH 4/6] emacs: simplify our local copy of message-do-fcc Mark Walters
2016-09-03 20:20 ` David Bremner
2016-09-03 21:42 ` Mark Walters
2016-09-03 22:36 ` David Bremner
2016-06-10 23:02 ` [PATCH 5/6] Modify " Mark Walters
2016-09-03 20:33 ` David Bremner
2016-09-03 21:39 ` Mark Walters
2016-09-03 22:37 ` David Bremner [this message]
2016-06-10 23:02 ` [PATCH 6/6] emacs: maildir: add the actual insert code Mark Walters
2016-09-03 20:43 ` [PATCH 0/6] Use notmuch insert for fcc David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg50k3tq.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).