From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 9D00F6DE0B64 for ; Sat, 3 Sep 2016 14:40:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.351 X-Spam-Level: X-Spam-Status: No, score=-0.351 tagged_above=-999 required=5 tests=[AWL=0.219, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JFkxuRiVX706 for ; Sat, 3 Sep 2016 14:39:59 -0700 (PDT) Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 543296DE0B2F for ; Sat, 3 Sep 2016 14:39:59 -0700 (PDT) Received: by mail-wm0-f65.google.com with SMTP id c133so7627266wmd.2 for ; Sat, 03 Sep 2016 14:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version; bh=ZnIUVbtPie5cmQSZIr5Usg2dOoRmPPMdLR9NCsPHF5g=; b=J2ceKGVQZDMMlECxMsVl9NzFaDr1BwfVBk3SuD5sFVfMYb8vnYFTsiA3AcbdnCa+EM /Ji9vKsZVf5Fn32+2dOHLHGUEYRSUX9kwTNP17ciWfsh28E+X/ep/EaZNsSHfDdW4UGa Sm6utq/LmbZv7Q+wgD/PHZCnSEZPyBPH/kM3SoTyaz1ijczNp0zJQT4Dvq55abGfLQ5S J86TNuQX2txhWGGD5uCQit2mbWZ1UbsVvjSHkOsA8zSqRWiHf8oaHPnyq0SY5Is4F6vm QY22ANe6zqKvQ5Bzlcoa0DJAKgPIXJpISKd1WdaqRpzOQnN07Drpt0QsdFZxw8IKG4e2 T75A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=ZnIUVbtPie5cmQSZIr5Usg2dOoRmPPMdLR9NCsPHF5g=; b=BYcZW1I6FgdgxKiInCJCsgr/swau+aaGtekZfjY30EGDOPCGo3rRJqg8pjC9wXd7BT NBE3mNrv26/PvPp2wpRFlqCvP/rymjQa8BoJGKL6OvHpfhd9qfONpWYf0j1h2rvrgF0u c0LvYXpSC96P0esaKeHTzsNZGbjoBfXuB+7Dsq8GOWNGWe/f5ABFoZycgN4utiL1WpVT BdU2fNGk+NFiP+LAFxFxmKJ6h3nVbaWpzo35LZAgB69JdTP1W5uRCKPebycjSpeYjq1R 6WT8QnNVZjPx2mg7cOm9oaXj10bzJjf8e9XK1HgbR2fZSAKigpmcgmH/WOMhaSrioibm LOEw== X-Gm-Message-State: AE9vXwNvm5bny+h1sdHB5Yu4+a69O1hSeoNgqUOw8ib4kVM3CbMPmx6/K4mT1eET3VCmow== X-Received: by 10.28.142.2 with SMTP id q2mr8423558wmd.119.1472938797368; Sat, 03 Sep 2016 14:39:57 -0700 (PDT) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id 137sm4867709wmi.16.2016.09.03.14.39.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Sep 2016 14:39:56 -0700 (PDT) From: Mark Walters To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 5/6] Modify our local copy of message-do-fcc In-Reply-To: <87vaycg1vc.fsf@maritornes.cs.unb.ca> References: <1465599772-10297-1-git-send-email-markwalters1009@gmail.com> <1465599772-10297-6-git-send-email-markwalters1009@gmail.com> <87vaycg1vc.fsf@maritornes.cs.unb.ca> User-Agent: Notmuch/0.18.1+485~gca076ce (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sat, 03 Sep 2016 22:39:56 +0100 Message-ID: <87eg503bo3.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Sep 2016 21:40:00 -0000 Many thanks for the review. On Sat, 03 Sep 2016, David Bremner wrote: > Mark Walters writes: > >> + (cons '("Newsgroups" . default) >> + rfc2047-header-encoding-alist))) > this seems like more message-mode functionality we don't need? I guess > it's harmless, but could omit one dynamically bound variable. I agree this might as well be removed. >> + (while list >> + (setq file (pop list)) >> + (notmuch-fcc-handler file)) >> + (kill-buffer (current-buffer))))))) > > Is it sensible for us to support a list of output destinations? It seems > like an odd corner case to me. I guess the amount of extra code is not > too high. In any case I suppose it could be a followup (as could my > comment above). We get a list here if someone has more than one fcc header. I don't know why they would want to, but gnus supported it so I kept it. I am happy either way here. Best wishes Mark