From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: "id buttonization" test failure
Date: Sat, 08 Oct 2016 09:33:39 -0300 [thread overview]
Message-ID: <87eg3r3tr0.fsf@zancas.localnet> (raw)
In-Reply-To: <8737k7lj9s.fsf@zancas.localnet>
David Bremner <david@tethera.net> writes:
> 2) I can interactively duplicate a similar, but not identical, bug as
> follows.
>
> - add the attached message (extracted from the test suite) to my mail
> store
> - open it notmuch-show (emacs 25.1, gtk/GUI)
> - go to the last line of the body. By using C-u C-x =, we can observe
> that the first and third copies of mid:abc are buttonized, but not
> the second.
> - this can also be seen by using the tab button.
The following "fixes" this test failure. This suggests to me something
that only fails when notmuch-show-buttonise-links is called from the C
redisplay code, and not when it's called from lisp.
diff --git a/test/T450-emacs-show.sh b/test/T450-emacs-show.sh
index 0342a87..afa75bd 100755
--- a/test/T450-emacs-show.sh
+++ b/test/T450-emacs-show.sh
@@ -129,7 +129,8 @@ cid:xxx
mid:abc mid:abc/def
mid:abc%20def
mid:abc. mid:abc, mid:abc;"'
-test_emacs '(notmuch-show "id:'$gen_msg_id'")
+test_emacs '(jit-lock-debug-mode)
+ (notmuch-show "id:'$gen_msg_id'")
(notmuch-test-mark-links)
(test-visible-output "OUTPUT.raw")'
cat <<EOF >EXPECTED
next prev parent reply other threads:[~2016-10-08 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 2:44 "id buttonization" test failure Marius Bakke
2016-10-06 13:08 ` David Bremner
2016-10-08 1:30 ` David Bremner
2016-10-08 12:33 ` David Bremner [this message]
2016-10-09 15:47 ` David Bremner
2016-10-09 22:30 ` [PATCH] emacs/show: force notmuch-show-buttonise-links to act on lines David Bremner
2016-10-10 18:30 ` Tomi Ollila
2016-10-11 11:25 ` David Bremner
2016-10-12 1:49 ` David Bremner
2016-10-12 2:05 ` "id buttonization" test failure David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg3r3tr0.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).