unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] build: add optional target parameter to quiet variable function
Date: Tue, 29 Aug 2017 22:36:45 -0300	[thread overview]
Message-ID: <87efrt25w2.fsf@tethera.net> (raw)
In-Reply-To: <20170829182709.26841-2-jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> Sometimes using $@ as the target in the quiet build lines can be
> confusing. Accept an optional second parameter in the quiet variable
> function to specify the target.

I'm OK with this, but I wondered about a simpler change: always use $<.
I doesn't strictly make sense to write "CXX  -g -O2
test/make-db-version.o". When is $@ better here?

d

  parent reply	other threads:[~2017-08-30  1:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 18:27 [PATCH 1/3] build: avoid an extra shell out in quiet variable function Jani Nikula
2017-08-29 18:27 ` [PATCH 2/3] build: add optional target parameter to " Jani Nikula
2017-08-29 21:48   ` Tomi Ollila
2017-08-30  1:36   ` David Bremner [this message]
2017-08-30 15:10     ` Jani Nikula
2017-08-30 15:27       ` David Bremner
2017-08-29 18:27 ` [PATCH 3/3] build: add .deps to CLEAN instead of listing in clean target Jani Nikula
2017-08-30 23:23 ` [PATCH 1/3] build: avoid an extra shell out in quiet variable function David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efrt25w2.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).