From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 02D576DE1333 for ; Mon, 20 May 2019 05:35:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M9XRWmY5S_0w for ; Mon, 20 May 2019 05:35:13 -0700 (PDT) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by arlo.cworth.org (Postfix) with ESMTPS id 10FCA6DE1309 for ; Mon, 20 May 2019 05:35:13 -0700 (PDT) Received: by mail-wm1-f68.google.com with SMTP id n25so12452755wmk.4 for ; Mon, 20 May 2019 05:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:in-reply-to:date:message-id:mime-version; bh=jlPr/5sM3Fg9Z6go1+d7Qjmx0vIEFgsx8ZPckCXv2Ck=; b=VvzYZWyPbHIYSO2JwYTPWJFArizOLG2OHiTayxo6lAQrleBnZ2inYbtuXGYoEKHRk+ 8nwakm+x6CXGMDTJFaT0680aqcXz9IVWF8LTZrFSZqaxr5rWPPsWNFR0X/k9ZzEJRZp5 zaPRGJv/jaszW5qEem1Ws2Ef286OzZJ1Y2ZrYiQXg3MZ/u4Z0qiwxklLSqoYTVswMwvb 3F4SCAqadAHmPDZz2Z34vrKouLG+RGcWkR2el3U4rMuPKos/v7HGxdbgWCxTgkObKWXx 56GW5dBaSRsJaLObh3amE4QrIAukmN3OrPYnpbycxADTf9um4A7SZ9JHm597ennhXwrU MbcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:date :message-id:mime-version; bh=jlPr/5sM3Fg9Z6go1+d7Qjmx0vIEFgsx8ZPckCXv2Ck=; b=KxumXq7dkgVn39FO4oKBAFvbND9TtzG262GdRgn4FNvBNMLlO3dBvW4JbtdJ7AsRc8 WhPAXk2UeXnyGFD7PgejsIMUaCalWkP7zN1aIT9ZP89Mc79LmX6yjHJPUIuhcKAEghYe h7/HdIYMQISPGZd/3cNsOup4OM1UWzuhcKoUH3h3hgSmIsX15wQWnAYDKUzGaGPY4l0J HTZv2LWqIzW6jJUSefLuP+5hSgbKOinTIIHfWVwmdhdNMKoPSIPY63GriqpVRQC545v1 yYd/SBeIMB3oym3qZadzxmPl/+4x7U7dmQEf0GhaaPqfUgI7DoHmiwgTVdnpHVohQ++y oHsg== X-Gm-Message-State: APjAAAXOGPS7LUE0kMI1cB6PVatUa4z9qrCAgmuHAqcjSXsKAZYd5hj9 1tAFZKKO81hyr0XWQW5csILeLxk= X-Google-Smtp-Source: APXvYqyIzveXy6eARQTtASwdB+gOLVJe2CBQhSGZ+Y9p3GIDrssV9OgBfnxCyu3NQ3h6n1r1silb9A== X-Received: by 2002:a1c:e144:: with SMTP id y65mr40816811wmg.147.1558355710740; Mon, 20 May 2019 05:35:10 -0700 (PDT) Received: from thinkpad.localdomain (lcs07-lyo-176-188-242-162.sfr.lns.abo.bbox.fr. [176.188.242.162]) by smtp.gmail.com with ESMTPSA id f126sm5450822wmf.30.2019.05.20.05.35.08 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 05:35:09 -0700 (PDT) Sender: Leo Vivier From: Leo Vivier To: notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region In-Reply-To: <87sgtqfvz2.fsf@tethera.net> Date: Mon, 20 May 2019 14:35:06 +0200 Message-ID: <87ef4tcnid.fsf@hidden> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailman-Approved-At: Mon, 20 May 2019 10:03:28 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 12:35:14 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, With the patch now in master, the documentation for Emacs (=E2=80=98Tips and Tricks for using Notmuch with Emacs=E2=80=99) needs to be updated: https://notmuchmail.org/emacstips/#index5h2 =E2=80=98notmuch-search-interactive-region=E2=80=99 is mentioned in the sec= ond block of Elisp. Also, could we mark the old function as obsolete? Some of my commands broke after pulling the changes, and that=E2=80=99s what led me to the doc = in the first place. I=E2=80=99ve attached a quick patch for marking the old command as obsolete= . I don't think the `emacstips' doc is in the repo, so I couldn't fix it. Best, --=20 Leo Vivier --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-emacs-make-old-function-obsolete.patch >From 5481c2fe61d9e776d15166bc46f8dfc6221bf975 Mon Sep 17 00:00:00 2001 From: Leo Vivier Date: Mon, 20 May 2019 14:21:13 +0200 Subject: [PATCH] emacs: make old function obsolete `notmuch-search-interactive-region' was moved to notmuch-lib.el in f3cba19f882471a396a6b6175a709ccd1f6f34a0 and renamed to `notmuch-interactive-region' without making the old function obsolete, thereby breaking user-commands which made use of it. This patch marks the function as obsolete and makes it an alias for the new function. --- emacs/notmuch-lib.el | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index 7fc342a5..96a1da90 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -1017,6 +1017,11 @@ region if the region is active, or both `point' otherwise." (list (region-beginning) (region-end)) (list (point) (point)))) +(define-obsolete-function-alias + 'notmuch-search-interactive-region + 'notmuch-interactive-region + "notmuch 0.28.1") + (provide 'notmuch-lib) ;; Local Variables: -- 2.21.0 --=-=-=--