From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 459466DE1097 for ; Sat, 27 Jul 2019 16:39:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.051 X-Spam-Level: X-Spam-Status: No, score=-0.051 tagged_above=-999 required=5 tests=[AWL=-0.050, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vRBrkdLtSJwq for ; Sat, 27 Jul 2019 16:39:20 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id D6A286DE0F8C for ; Sat, 27 Jul 2019 16:39:19 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hrWHS-00017j-BV; Sat, 27 Jul 2019 19:39:14 -0400 Received: (nullmailer pid 29952 invoked by uid 1000); Wed, 24 Jul 2019 20:56:54 -0000 From: David Bremner To: Ralph Seichter , notmuch@notmuchmail.org Subject: Re: [PATCH] notmuch-dump.c: Fix output file being closed twice In-Reply-To: <87pnm0s7yw.fsf@tethera.net> References: <20190723203002.31110-1-abbot@monksofcool.net> <20190723204823.31665-1-abbot@monksofcool.net> <20190723204823.31665-2-abbot@monksofcool.net> <87pnm0s7yw.fsf@tethera.net> Date: Wed, 24 Jul 2019 17:56:54 -0300 Message-ID: <87ef2frw15.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jul 2019 23:39:22 -0000 David Bremner writes: > Ralph Seichter writes: > >> Fixed: If the output file for a dump was non-writeable, gzclose_w() >> was called twice on the output file handle, resulting in SIGABRT. > > LGTM, although I did have to revert one unrelated whitespace change. > > I'll push that later if no-one objects. No one objected, pushed, d