unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Ralph Seichter <abbot@monksofcool.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-dump.c: Fix output file being closed twice
Date: Wed, 24 Jul 2019 17:56:54 -0300	[thread overview]
Message-ID: <87ef2frw15.fsf@tethera.net> (raw)
In-Reply-To: <87pnm0s7yw.fsf@tethera.net>

David Bremner <david@tethera.net> writes:

> Ralph Seichter <abbot@monksofcool.net> writes:
>
>> Fixed: If the output file for a dump was non-writeable, gzclose_w()
>> was called twice on the output file handle, resulting in SIGABRT.
>
> LGTM, although I did have to revert one unrelated whitespace change.
>
> I'll push that later if no-one objects.

No one objected, pushed,

d

      reply	other threads:[~2019-07-27 23:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-23 20:30 [PATCH] notmuch-dump.c: Fix output file being closed twice Ralph Seichter
2019-07-23 20:48 ` [PATCH] notmuch-dump.c: Fix output file being closed twice (V2) Ralph Seichter
2019-07-23 20:48   ` [PATCH] notmuch-dump.c: Fix output file being closed twice Ralph Seichter
2019-07-23 22:26     ` David Bremner
2019-07-24 20:56       ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef2frw15.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=abbot@monksofcool.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).