unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Teemu Likonen <tlikonen@iki.fi>
To: David Edmondson <dme@dme.org>,
	Steven Allen <steven@stebalien.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: don't start processes stopped
Date: Wed, 08 Jan 2020 17:38:48 +0200	[thread overview]
Message-ID: <87eewaklfb.fsf@iki.fi> (raw)
In-Reply-To: <m2r20gku4b.fsf@dme.org>

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

David Edmondson [2020-01-03T23:17:24Z] wrote:

> On Friday, 2020-01-03 at 09:04:00 -08, Steven Allen wrote:
>
>> It causes this function to fail with:
>>
>>     let: Wrong type argument: null, t
>>
>> Support for this was removed from Emacs in April
>> 2019 (5c5e309527e6b582e2c04b83e7af45f3144863ac) because it never
>> worked correctly (apparently).
>>
>> This also shouldn't be necessary as sentinels will not be called
>> unless emacs is idle or waiting for input. Therefore, the
>> `process-put' calls immediately following the `make-process' call
>> should always complete before the sentinel is first called.
>
> Reviewed-by: David Edmondson <dme@dme.org>

And tested by me: the patch fixes the key retrieval problem.

-- 
///  OpenPGP key: 4E1055DC84E9DFF613D78557719D69D324539450
//  https://keys.openpgp.org/search?q=tlikonen@iki.fi
/  https://keybase.io/tlikonen  https://github.com/tlikonen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 694 bytes --]

  reply	other threads:[~2020-01-08 15:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 17:04 [PATCH] emacs: don't start processes stopped Steven Allen
2020-01-03 23:17 ` David Edmondson
2020-01-08 15:38   ` Teemu Likonen [this message]
2020-01-09  1:28 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eewaklfb.fsf@iki.fi \
    --to=tlikonen@iki.fi \
    --cc=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    --cc=steven@stebalien.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).