From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8BstCHhdGV/aFQAA0tVLHw (envelope-from ) for ; Thu, 23 Jul 2020 09:50:48 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IOL5A3hdGV9tMQAAB5/wlQ (envelope-from ) for ; Thu, 23 Jul 2020 09:50:48 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A2AA29403CB for ; Thu, 23 Jul 2020 09:50:46 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C5A8D20058; Thu, 23 Jul 2020 05:50:35 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id AD5161FA20 for ; Thu, 23 Jul 2020 05:50:32 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id A2FFA60AB7; Thu, 23 Jul 2020 05:50:30 -0400 (EDT) Received: (nullmailer pid 774791 invoked by uid 1000); Thu, 23 Jul 2020 09:50:29 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [Kevin McCarthy] Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes with a space in the name References: <159546998738.232977.10166967333633103899.reportbug@afu.lan> X-List-To: notmuch Date: Thu, 23 Jul 2020 06:50:29 -0300 Message-ID: <87eep2o90a.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ZSI7UWK7LJ3UHJF4GYFLQSYWASUNKNRA X-Message-ID-Hash: ZSI7UWK7LJ3UHJF4GYFLQSYWASUNKNRA X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============5509495857833357627==" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -0.97 X-TUID: Qn6aIqIEjdlB --===============5509495857833357627== Content-Type: message/rfc822 Content-Disposition: inline Return-Path: X-Original-To: david@tethera.net Delivered-To: david@tethera.net Received: from mailly.debian.org (mailly.debian.org [IPv6:2001:41b8:202:deb:6564:a62:52c3:4b72]) by fethera.tethera.net (Postfix) with ESMTPS id 47BD660AB6 for ; Wed, 22 Jul 2020 22:21:10 -0400 (EDT) Received: from ticharich.debian.org ([2607:f8f0:614:1::1274:64]:48328) from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=ticharich.debian.org,EMAIL=hostmaster@ticharich.debian.org (verified) by mailly.debian.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyQr7-0000vC-3I for david@tethera.net; Thu, 23 Jul 2020 02:21:09 +0000 Received: from localhost ([::1]:44232 helo=ticharich.debian.org) by ticharich.debian.org with esmtp (Exim 4.92) (envelope-from ) id 1jyQr5-0003kz-PD for david@tethera.net; Thu, 23 Jul 2020 02:21:07 +0000 Received: from muffat.debian.org ([2607:f8f0:614:1::1274:33]:60486) from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=muffat.debian.org,EMAIL=hostmaster@muffat.debian.org (verified) by ticharich.debian.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyQr5-0003ks-I2 for dispatch+notmuch@tracker.debian.org; Thu, 23 Jul 2020 02:21:07 +0000 Received: from quantz.debian.org ([2607:f8f0:614:1::1274:73]:57056) from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=quantz.debian.org,EMAIL=hostmaster@quantz.debian.org (verified) by muffat.debian.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyQr5-0000jI-0L for dispatch+notmuch@tracker.debian.org; Thu, 23 Jul 2020 02:21:07 +0000 Received: from qa by quantz.debian.org with local (Exim 4.92) (envelope-from ) id 1jyQr4-0001Ez-Fj for dispatch+notmuch@tracker.debian.org; Thu, 23 Jul 2020 02:21:06 +0000 Received: from buxtehude.debian.org ([2607:f8f0:614:1::1274:39]:44582) from C=NA,ST=NA,L=Ankh Morpork,O=Debian SMTP,OU=Debian SMTP CA,CN=buxtehude.debian.org,EMAIL=hostmaster@buxtehude.debian.org (verified) by quantz.debian.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyQr4-0001Eg-7I for notmuch@packages.qa.debian.org; Thu, 23 Jul 2020 02:21:06 +0000 Received: from debbugs by buxtehude.debian.org with local (Exim 4.92) (envelope-from ) id 1jyQr1-0001Q4-VB; Thu, 23 Jul 2020 02:21:03 +0000 X-Loop: owner@bugs.debian.org Subject: Bug#966100: notmuch-mutt: symlinking now fails for indexed mailboxes with a space in the name Reply-To: Kevin McCarthy , 966100@bugs.debian.org Resent-From: Kevin McCarthy Resent-To: debian-bugs-dist@lists.debian.org Resent-CC: Carl Worth X-Loop: owner@bugs.debian.org Resent-Date: Thu, 23 Jul 2020 02:21:01 +0000 Resent-Message-ID: X-Debian-PR-Message: report 966100 X-Debian-PR-Package: notmuch-mutt X-Debian-PR-Keywords: upstream X-Debian-PR-Source: notmuch Received: via spool by submit@bugs.debian.org id=B.15954705923593 (code B); Thu, 23 Jul 2020 02:21:01 +0000 Received: (at submit) by bugs.debian.org; 23 Jul 2020 02:16:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.2-bugs.debian.org_2005_01_02 (2018-09-13) on buxtehude.debian.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=4.0 tests=BAYES_00,DIGITS_LETTERS, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FOURLA,HAS_PACKAGE, MD5_SHA1_SUM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,TXREP,XMAILER_REPORTBUG autolearn=ham autolearn_force=no version=3.4.2-bugs.debian.org_2005_01_02 X-Spam-Bayes: score:0.0000 Tokens: new, 54; hammy, 150; neutral, 119; spammy, 0. spammytokens: hammytokens:0.000-+--commitdiff, 0.000-+--HX-ME-Sender:xms, 0.000-+--H*M:reportbug, 0.000-+--H*MI:reportbug, 0.000-+--H*x:reportbug Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:51317) by buxtehude.debian.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jyQme-0000vf-9a for submit@bugs.debian.org; Thu, 23 Jul 2020 02:16:32 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 7603617F7; Wed, 22 Jul 2020 22:06:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 22 Jul 2020 22:06:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=8t8.us; h= content-type:mime-version:content-transfer-encoding:from:to :subject:message-id:date; s=fm3; bh=pssaFBxY5CUVH6Cl8mG35qfhEoAH IQq6bVay/n7Pvqs=; b=P8K004sJL3+KU68GAY60CoNMijH15nWE+9h591YgxVeB nKm2/zftf567HofFm/3WRYM4nzyY6fIiHr6hY3+EJdQak8+dg+ec+l95BU3ArIIi ZP+B6GQB0cXnHe/JYXabNYCKizOcAToPbXBPJJkdU1PXe+i1PMJMGX0u7ycsu9Yx yENzeeFnuECFtYFOpuVsokLDAfOEZUF9T81xVVVx4LQ68+ZduBSUamy41g6DVCZy pO7YExlUx/yNdCK81dUnwMX7CKYtoZ9D2H16yXaQpx4BukbiLEXF88blTrLN0N24 Ef/xsSxchzRVrbpuiJVD3vAOY/YCwueQ5s56r3h/aA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=pssaFB xY5CUVH6Cl8mG35qfhEoAHIQq6bVay/n7Pvqs=; b=XTZer+4+o03RoQvI8ypRmR D1buVGYcdrxLqMf1YSBBSJ7IibU5PhByY3rcE0vCGHL6hQy1ZYElh+iuQkvkNes3 DJXVPuxpT6tDbSGxlPzxIy3sxNeehr5rYgK9f/U09Mixeb3hWuCgg4iEQNezeONL seQ+K091+Q8CT9eioejT3PQflCTWw6QvPV4aldSmRKi7iODkSBAhFLzrW5t30YAa O8b+aeLkst6A8H9f0r2RGZI4ttftmk//CErJ+g/Ok/1Q6OKJc8Z+seNeD0vQBviz gtEilM4sMHafD82zomEW1g90vIkZwicwRVZtx+VnQjD4eupiQ2QH9uQCoVf92xPA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrhedtgdehhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurheptggggffhvffukffoffesthejredtre dtvdenucfhrhhomhepmfgvvhhinhcuofgtvegrrhhthhihuceokhgvvhhinheskehtkedr uhhsqeenucggtffrrghtthgvrhhnpeeuleekudelfefhgffhvdekhefhffetieevuddvff elheetuedtvdfgieefgeevhfenucffohhmrghinhepnhhothhmuhgthhhmrghilhdrohhr ghenucfkphepvddtkedrkeefrdduleekrddujedvnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepkhgvvhhinheskehtkedruhhs X-ME-Proxy: Received: from localhost (unknown [208.83.198.172]) by mail.messagingengine.com (Postfix) with ESMTPA id 2962F3280060; Wed, 22 Jul 2020 22:06:29 -0400 (EDT) From: Kevin McCarthy To: Debian Bug Tracking System Message-ID: <159546998738.232977.10166967333633103899.reportbug@afu.lan> X-Mailer: reportbug 7.7.0 Date: Wed, 22 Jul 2020 19:06:27 -0700 X-Greylist: delayed 599 seconds by postgrey-1.36 at buxtehude; Thu, 23 Jul 2020 02:16:31 UTC Delivered-To: submit@bugs.debian.org Delivered-To: notmuch@packages.qa.debian.org Delivered-To: dispatch+notmuch@tracker.debian.org X-Loop: dispatch@tracker.debian.org X-Distro-Tracker-Keyword: bts X-Distro-Tracker-Package: notmuch List-Id: X-Debian: tracker.debian.org X-Debian-Package: notmuch X-PTS-Package: notmuch X-PTS-Keyword: bts Precedence: list List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Package: notmuch-mutt Version: 0.30-1 Severity: important Tags: upstream Dear Maintainer, After recently updating from stable to testing, notmuch-mutt search and thread commands stopped including results from my "Sent Items" maildir folder. There are broken links in the results folder, and symlink error messages in the terminal window after exiting mutt. I tracked this down to upstream commit but unfortunately my shell-fu is not good enough to understand exactly why the new version isn't working. If I manually swap revert the diff then my Sent Items results start working again. So somehow the backslash-escaping works for xargs but not for the shell while/read loop. Here's the part of the commit above causing the breakage. - - - - - - - - - diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt index 0e46a8c1b95e76163eed68694aa5a1a973c8b371..d33223bdd88e776acf79ae8b4ba2703ff1e6cc58 100755 (executable) --- a/contrib/notmuch-mutt/notmuch-mutt +++ b/contrib/notmuch-mutt/notmuch-mutt @@ -50,7 +50,7 @@ sub search($$$) { empty_maildir($maildir); system("notmuch search --output=files $dup_option $query" . " | sed -e 's: :\\\\ :g'" - . " | xargs -r -I searchoutput ln -s searchoutput $maildir/cur/"); + . " | while IFS= read -r searchoutput; do ln -s \$searchoutput $maildir/cur/; done"); } sub prompt($$) { - - - - - - - - - -- System Information: Debian Release: bullseye/sid APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 5.7.0-1-amd64 (SMP w/16 CPU threads) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages notmuch-mutt depends on: ii libmail-box-perl 3.008-1 ii libmailtools-perl 2.21-1 ii libstring-shellquote-perl 1.04-1 ii libterm-readline-gnu-perl 1.36-2+b1 ii notmuch 0.30-1 ii perl 5.30.3-4 Versions of packages notmuch-mutt recommends: pn mutt notmuch-mutt suggests no packages. -- no debconf information --===============5509495857833357627== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============5509495857833357627==--