From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id lsveF+1iDWBuGwAA0tVLHw (envelope-from ) for ; Sun, 24 Jan 2021 12:07:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MGVhE+1iDWCFFAAAB5/wlQ (envelope-from ) for ; Sun, 24 Jan 2021 12:07:09 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBA1094042B for ; Sun, 24 Jan 2021 12:07:07 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 84E6E2BF52; Sun, 24 Jan 2021 07:07:02 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 676D629D3C for ; Sun, 24 Jan 2021 07:07:00 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 8F240606D9; Sun, 24 Jan 2021 07:06:58 -0500 (EST) Received: (nullmailer pid 1348081 invoked by uid 1000); Sun, 24 Jan 2021 12:06:56 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 01/38] lib: add _notmuch_string_map_set In-Reply-To: References: <20210116170406.842014-1-david@tethera.net> <20210116170406.842014-2-david@tethera.net> Date: Sun, 24 Jan 2021 08:06:56 -0400 Message-ID: <87eeiabktb.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: YQL63HKEIU5G65NZ3R532QPZYZVNRWWR X-Message-ID-Hash: YQL63HKEIU5G65NZ3R532QPZYZVNRWWR X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: CBA1094042B X-Spam-Score: -2.07 X-Migadu-Scanner: scn1.migadu.com X-TUID: mZWRxmg32FZ3 Tomi Ollila writes: > On Sat, Jan 16 2021, David Bremner wrote: > > > First, is this patch series safe to be applied and put into use ? :D At least the backwards compatibility part is pretty well tested. I have been running variations of it for a month or so. > > The style in string-map.c (and matches the .h above) would indicate the abobe should be: > > _notmuch_string_map_set (notmuch_string_map_t *map, > const char *key, > const char *val) > Sure. Although I think string-map.c is not completely consistent, that is no reason not to match the header for new stuff. d