From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ACMxJG7xCWFWDwAAgWs5BA (envelope-from ) for ; Wed, 04 Aug 2021 03:46:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EJX+H27xCWECdQAAB5/wlQ (envelope-from ) for ; Wed, 04 Aug 2021 01:46:22 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 02B3A3B21 for ; Wed, 4 Aug 2021 03:46:21 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DC20A2C0BE; Tue, 3 Aug 2021 21:46:16 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 65C5A2C0BD for ; Tue, 3 Aug 2021 21:46:15 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5896C5FD5C; Tue, 3 Aug 2021 21:46:14 -0400 (EDT) Received: (nullmailer pid 3768327 invoked by uid 1000); Wed, 04 Aug 2021 01:46:13 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] test: aggregate-results updates In-Reply-To: References: <20210517081109.31897-1-tomi.ollila@iki.fi> <874kc814q8.fsf@tethera.net> Date: Tue, 03 Aug 2021 22:46:13 -0300 Message-ID: <87eebax9qy.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: PIBRIVNRZHCIW32HYOFIVTCQGKVFUPBH X-Message-ID-Hash: PIBRIVNRZHCIW32HYOFIVTCQGKVFUPBH X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628041581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=n0zqLCDVnl8NiqVn6aflMP+GHvs05c11ISxuTbUwJys=; b=L7xD2juZfXQmOi9Jxc9hSsTlg7kp8mtfZ4sLMW9/4mGKogHRBnBf1T01k3L+L6BzEpwGeT GRBEsNJmKY64Bx+yjLVrLchK/ORWBrMgX2Is4HeFZ92N/XIu7zVsebKjREHFI+rZcnUsL6 Y8EWAsoP74xREwfIbkik+6Q0bUHfmq3uJWNMxETwm0CRga5xYEDAqUhcIwNkIknb6J9R90 uf+cqkeu6xrj4P4kmcp9F7nyXJ7ocLNve3jjCLhNR3J9Puig/1yAVW0OseFj8ZQx0DoEUr cLdoXd2erA2oewCGf0ZIEcyThcy7sd0nGrcejX/L0j/zq+wP+b1Y14X2YKLCcA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628041581; a=rsa-sha256; cv=none; b=GPoysHzCrh8o/eJ42XZBG9xoLR4DWW8dnv6f6ju9g8mQ48X8fpDq4F9vkdvLD5svwAC29U +bePKJ7spKhJi6Lo63ddsIURuo5uOMGNcTPK8iECiHbj1cbEyFbt0kBkdg7H83MCegny2u hvlPzVxcqyunJ1emckzr6aGfNshHIcu0sso/Q0FoCct2xb9OcFOxMrEurkqB2/UB1lwN3T cva+8CToWj2CSv585uvSCBTwi2Nawy0o1GSkgVSWY8ciYnP6CEHbX41CXO6I67i7XjTNpa NhIWVwhkSWj5O9HBckn1D5VwOTKfdVEZHszBHf596c3u4L/2LEMYsIriWISvlQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 02B3A3B21 X-Spam-Score: -2.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4mRBJYIgRp1X Tomi Ollila writes: > On Mon, Aug 02 2021, David Bremner wrote: > >> Tomi Ollila writes: >> >>> - mkdir -p "$test_results_dir" >>> + test -d "$test_results_dir" || mkdir "$test_results_dir" >> >> Lately I've notice some complaints during parallel test running >> >> mkdir: cannot create directory '/home/bremner/software/upstream/notmuch/test/test-results': File exists >> >> It seems like this change might be the culprit. Can you explain why it >> was needed? > > ah, parallel test non-atomicity is the problem; fix would be to restore -p to mkdir > (so it does not fail when another program executed mkdir between that test > check and mkdir execution) > Switched back to mkdir -p here, the occasional test failure is worse than the potential slowdown. d