[PATCH] configure: use pkg-config for gpgme

[PATCH] configure: use pkg-config for gpgme

[Daniel Kahn Gillmor]

GnuPG upstream has supported pkg-config since gpgme version 1.13 and
gpg-error 1.33, and now prefers the use of pkg-config by default,
instead of relying on gpg-error-config and gpgme-config.

As of libgpg-error 1.46, upstream deliberately does not ship
gpg-error-config by default.  As of gpgme 1.18.0, upstream does not
ship gpgme-config if gpg-error-config is also not present.

Both of these versions of upstream libraries are in debian unstable
now.  To the extent that notmuch is dependent on GnuPG, it should
follow GnuPG upstream's lead.

Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index be69b34d..c3629a73 100755
--- a/configure
+++ b/configure
@@ -541,8 +541,8 @@ version of GPGME.
 Please try to rebuild your version of GMime against a more recent
 version of GPGME (at least GPGME 1.8.0).
 EOF
-	if command -v gpgme-config >/dev/null; then
-	    printf 'Your current GPGME development version is: %s\n' "$(gpgme-config --version)"
+	if GPGME_VERS="$(pkg-config --modversion gpgme || gpgme-config --version)"; then
+	    printf 'Your current GPGME development version is: %s\n' "$GPGME_VERS"
 	else
 	    printf 'You do not have the GPGME development libraries installed.\n'
 	fi
-- 
2.35.1

Re: [PATCH] configure: use pkg-config for gpgme

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> GnuPG upstream has supported pkg-config since gpgme version 1.13 and
> gpg-error 1.33, and now prefers the use of pkg-config by default,
> instead of relying on gpg-error-config and gpgme-config.
>
> As of libgpg-error 1.46, upstream deliberately does not ship
> gpg-error-config by default.  As of gpgme 1.18.0, upstream does not
> ship gpgme-config if gpg-error-config is also not present.
>
> Both of these versions of upstream libraries are in debian unstable
> now.  To the extent that notmuch is dependent on GnuPG, it should
> follow GnuPG upstream's lead.

How is the (debian specific) story for backports?

d

Re: [PATCH] configure: use pkg-config for gpgme

[Daniel Kahn Gillmor]

[-- Attachment #1.1: Type: text/plain, Size: 1685 bytes --]

On Wed 2022-11-02 18:02:00 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> GnuPG upstream has supported pkg-config since gpgme version 1.13 and
>> gpg-error 1.33, and now prefers the use of pkg-config by default,
>> instead of relying on gpg-error-config and gpgme-config.
>>
>> As of libgpg-error 1.46, upstream deliberately does not ship
>> gpg-error-config by default.  As of gpgme 1.18.0, upstream does not
>> ship gpgme-config if gpg-error-config is also not present.
>>
>> Both of these versions of upstream libraries are in debian unstable
>> now.  To the extent that notmuch is dependent on GnuPG, it should
>> follow GnuPG upstream's lead.
>
> How is the (debian specific) story for backports?

I believe this patch leaves notmuch still fully backportable across
all supported debian versions that were already supported.

0 dkg@alice:~$ rmadison gpgme1.0
gpgme1.0   | 1.5.1-6         | oldoldoldstable         | source
gpgme1.0   | 1.8.0-3         | oldoldstable            | source
gpgme1.0   | 1.12.0-6~bpo9+1 | stretch-backports       | source
gpgme1.0   | 1.12.0-6~bpo9+1 | stretch-backports-debug | source
gpgme1.0   | 1.12.0-6        | oldstable               | source
gpgme1.0   | 1.14.0-1        | stable                  | source
gpgme1.0   | 1.18.0-1        | testing                 | source
gpgme1.0   | 1.18.0-2        | unstable                | source
gpgme1.0   | 1.18.0-2        | unstable-debug          | source
0 dkg@alice:~$

backporting to stable should use pkg-config, since the version there is
after 1.13.  for older than stable, the functionality will still fall
back to using legacy gpgme-config.

     --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] configure: use pkg-config for gpgme

[Daniel Kahn Gillmor]

[-- Attachment #1.1: Type: text/plain, Size: 2061 bytes --]

Just a nudge on this patch:

any chance we can have it applied in the notmuch tree?

    --dkg

On Fri 2022-11-11 05:16:31 -0500, Daniel Kahn Gillmor wrote:
> On Wed 2022-11-02 18:02:00 -0300, David Bremner wrote:
>> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>>
>>> GnuPG upstream has supported pkg-config since gpgme version 1.13 and
>>> gpg-error 1.33, and now prefers the use of pkg-config by default,
>>> instead of relying on gpg-error-config and gpgme-config.
>>>
>>> As of libgpg-error 1.46, upstream deliberately does not ship
>>> gpg-error-config by default.  As of gpgme 1.18.0, upstream does not
>>> ship gpgme-config if gpg-error-config is also not present.
>>>
>>> Both of these versions of upstream libraries are in debian unstable
>>> now.  To the extent that notmuch is dependent on GnuPG, it should
>>> follow GnuPG upstream's lead.
>>
>> How is the (debian specific) story for backports?
>
> I believe this patch leaves notmuch still fully backportable across
> all supported debian versions that were already supported.
>
> 0 dkg@alice:~$ rmadison gpgme1.0
> gpgme1.0   | 1.5.1-6         | oldoldoldstable         | source
> gpgme1.0   | 1.8.0-3         | oldoldstable            | source
> gpgme1.0   | 1.12.0-6~bpo9+1 | stretch-backports       | source
> gpgme1.0   | 1.12.0-6~bpo9+1 | stretch-backports-debug | source
> gpgme1.0   | 1.12.0-6        | oldstable               | source
> gpgme1.0   | 1.14.0-1        | stable                  | source
> gpgme1.0   | 1.18.0-1        | testing                 | source
> gpgme1.0   | 1.18.0-2        | unstable                | source
> gpgme1.0   | 1.18.0-2        | unstable-debug          | source
> 0 dkg@alice:~$
>
> backporting to stable should use pkg-config, since the version there is
> after 1.13.  for older than stable, the functionality will still fall
> back to using legacy gpgme-config.
>
>      --dkg
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] configure: use pkg-config for gpgme

[David Bremner]

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> Just a nudge on this patch:
>
> any chance we can have it applied in the notmuch tree?
>
>     --dkg
>

Applied to master.

d