From: Carl Worth <cworth@cworth.org>
To: Kan-Ru Chen <kanru@kanru.info>,
david@tethera.net, notmuch@notmuchmail.org
Subject: Re: Update Patch Series. Only collapse part of citations.
Date: Mon, 08 Feb 2010 14:31:47 -0800 [thread overview]
Message-ID: <87d40fpdf0.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <87637t3dtu.fsf@anar.kanru.info>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
> On Fri, 25 Dec 2009 16:09:06 -0400, david@tethera.net wrote:
> > On Fri, 25 Dec 2009 09:47:02 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> > > I like this idea, but this patch hides all citations larger than the
> > > threshold. I'd like to see limited lines of citations been displayed.
> >
> > Since you ask nicely, OK :).
Very nice work, David!
I've just used this for a few minutes here, and it's very nice. (The
previous code was hiding far too much of the citations and I found
myself having to open them all the time just to be able to read things.)
On Sun, 27 Dec 2009 00:22:21 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> Works great here.
>
> Reviewed-by: Kan-Ru Chen <kanru@kanru.info>
And thanks for the review. I've now committed and pushed these changes,
(with the reviewed-by added and some trailing whitespace removed).
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2010-02-08 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 0:47 wish: more informative citations David Bremner
2009-12-19 1:02 ` Carl Worth
2009-12-24 14:38 ` [PATCH] notmuch.el: Refactor citation markup. Variables for minimum size, button text david
2009-12-24 19:12 ` david
2009-12-25 1:47 ` Kan-Ru Chen
2009-12-25 20:09 ` Update Patch Series. Only collapse part of citations david
2009-12-25 20:09 ` [PATCH 1/2] notmuch.el: Refactor citation markup. Variables for minimum size, button text david
2009-12-25 20:09 ` [PATCH 2/2] notmuch.el: show some of citation even when hiding david
2009-12-26 16:22 ` Update Patch Series. Only collapse part of citations Kan-Ru Chen
2010-02-08 22:31 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d40fpdf0.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=david@tethera.net \
--cc=kanru@kanru.info \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).