* [PATCH] bug in notmuch-fcc-header-setup
@ 2010-11-30 14:58 Ladislav Lhotka
2010-11-30 15:02 ` David Edmondson
0 siblings, 1 reply; 3+ messages in thread
From: Ladislav Lhotka @ 2010-11-30 14:58 UTC (permalink / raw)
To: notmuch
Hi,
the check for old-style setting of notmuch-fcc-dirs doesn't work because 'length' function cannot be applied to a cons cell. The following patch should fix this bug.
Cheers, Ladislav
diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el
index e5e0549..27ac955 100644
--- a/emacs/notmuch-maildir-fcc.el
+++ b/emacs/notmuch-maildir-fcc.el
@@ -88,7 +88,7 @@ will NOT be removed or replaced."
notmuch-fcc-dirs)
((and (listp notmuch-fcc-dirs)
- (= 1 (length (car notmuch-fcc-dirs))))
+ (not (cdar notmuch-fcc-dirs)))
;; Old style - no longer works.
(error "Invalid `notmuch-fcc-dirs' setting (old style)"))
--
Ladislav Lhotka, CESNET
PGP Key ID: E74E8C0C
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bug in notmuch-fcc-header-setup
2010-11-30 14:58 [PATCH] bug in notmuch-fcc-header-setup Ladislav Lhotka
@ 2010-11-30 15:02 ` David Edmondson
2010-12-02 17:45 ` Ladislav Lhotka
0 siblings, 1 reply; 3+ messages in thread
From: David Edmondson @ 2010-11-30 15:02 UTC (permalink / raw)
To: Ladislav Lhotka, notmuch
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
On Tue, 30 Nov 2010 15:58:53 +0100, Ladislav Lhotka <lhotka@cesnet.cz> wrote:
> the check for old-style setting of notmuch-fcc-dirs doesn't work
> because 'length' function cannot be applied to a cons cell. The
> following patch should fix this bug.
A fix (plus tests) is included in
id:"1290682750-30283-2-git-send-email-dme@dme.org".
dme.
--
David Edmondson, http://dme.org
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bug in notmuch-fcc-header-setup
2010-11-30 15:02 ` David Edmondson
@ 2010-12-02 17:45 ` Ladislav Lhotka
0 siblings, 0 replies; 3+ messages in thread
From: Ladislav Lhotka @ 2010-12-02 17:45 UTC (permalink / raw)
To: David Edmondson; +Cc: notmuch
On Út, 2010-11-30 at 15:02 +0000, David Edmondson wrote:
> On Tue, 30 Nov 2010 15:58:53 +0100, Ladislav Lhotka <lhotka@cesnet.cz> wrote:
> > the check for old-style setting of notmuch-fcc-dirs doesn't work
> > because 'length' function cannot be applied to a cons cell. The
> > following patch should fix this bug.
>
> A fix (plus tests) is included in
> id:"1290682750-30283-2-git-send-email-dme@dme.org".
OK, thanks, I missed that one.
Lada
>
> dme.
--
Ladislav Lhotka, CESNET
PGP Key ID: E74E8C0C
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-02 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-30 14:58 [PATCH] bug in notmuch-fcc-header-setup Ladislav Lhotka
2010-11-30 15:02 ` David Edmondson
2010-12-02 17:45 ` Ladislav Lhotka
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).