From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 86712417332 for ; Fri, 24 Feb 2012 02:44:19 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1J9hYhagncjt for ; Fri, 24 Feb 2012 02:44:19 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id AD997417330 for ; Fri, 24 Feb 2012 02:44:18 -0800 (PST) Received: by bkcit16 with SMTP id it16so2023133bkc.26 for ; Fri, 24 Feb 2012 02:44:17 -0800 (PST) Received-SPF: pass (google.com: domain of dmitry.kurochkin@gmail.com designates 10.205.127.130 as permitted sender) client-ip=10.205.127.130; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmitry.kurochkin@gmail.com designates 10.205.127.130 as permitted sender) smtp.mail=dmitry.kurochkin@gmail.com; dkim=pass header.i=dmitry.kurochkin@gmail.com Received: from mr.google.com ([10.205.127.130]) by 10.205.127.130 with SMTP id ha2mr849783bkc.28.1330080257256 (num_hops = 1); Fri, 24 Feb 2012 02:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=N53Q/VC1UW4XoBG7ClauPBsxrcjQZNRdP9Y/HHxAQMk=; b=PZihcSANEcMbkUjBTVLdpuw6g9sK/jkqla0hIgf1qXEP548FEsBDB22ZvtwC5GFsxu v0fenKCVtUi1da3TckrCmrSwv85BiYxmLUYAG+wzMBmBVim31OyYbvV5W19PLNBRICrX +faVdNcqlMxaQGbglUeiGEYBZeP/GIKddLCoA= Received: by 10.205.127.130 with SMTP id ha2mr707195bkc.28.1330080257191; Fri, 24 Feb 2012 02:44:17 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id i2sm7867207bkd.10.2012.02.24.02.44.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 02:44:16 -0800 (PST) From: Dmitry Kurochkin To: Pieter Praet , David Bremner Subject: Re: [PATCH 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}' In-Reply-To: <1330038554-10347-5-git-send-email-pieter@praet.org> References: <878vjtqhcg.fsf@praet.org> <1330038554-10347-5-git-send-email-pieter@praet.org> User-Agent: Notmuch/0.11.1+188~ga5674c2 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 24 Feb 2012 14:42:53 +0400 Message-ID: <87d394jyvm.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 10:44:19 -0000 On Fri, 24 Feb 2012 00:09:13 +0100, Pieter Praet wrote: > * emacs/notmuch-show.el > > (notmuch-show-get-messages-ids): > If provided with optional arg SEPARATOR, return a string consisting > of all Message-Id's, separated by SEPARATOR. Also improve original > docstring wrt default return value. > > (notmuch-show-get-messages-ids-search): > Removed, as its functionality is now in `notmuch-show-get-messages-ids'. > > (notmuch-show-tag-all): > Call `notmuch-show-get-messages-ids' with SEPARATOR arg instead of > `notmuch-show-get-messages-ids-search'. > --- There is another similar case in notmuch.el: `notmuch-show-get-messages-ids' and `notmuch-show-get-messages-ids-search'. There may be more. Please change them as well. Regards, Dmitry > emacs/notmuch-show.el | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index 5fc0e43..4b37c77 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -1334,17 +1334,17 @@ (defun notmuch-show-get-message-id () > "Return the message id of the current message." > (concat "id:\"" (notmuch-show-get-prop :id) "\"")) > > -(defun notmuch-show-get-messages-ids () > - "Return all message ids of messages in the current thread." > +(defun notmuch-show-get-messages-ids (&optional separator) > + "Return a list of Message-Id's of all messages in the current buffer. > + > +If provided with optional argument SEPARATOR, return a string > +instead, consisting of all Message-Id's separated by SEPARATOR." > (let ((message-ids)) > (notmuch-show-mapc t > (lambda () (push (notmuch-show-get-message-id) message-ids))) > - message-ids)) > - > -(defun notmuch-show-get-messages-ids-search () > - "Return a search string for all message ids of messages in the > -current thread." > - (mapconcat 'identity (notmuch-show-get-messages-ids) " or ")) > + (if separator > + (mapconcat 'identity message-ids separator) > + message-ids))) > > ;; dme: Would it make sense to use a macro for many of these? > > @@ -1633,7 +1633,7 @@ (defun notmuch-show-tag-all (&rest tag-changes) > > TAG-CHANGES is a list of tag operations for `notmuch-tag'." > (interactive (notmuch-read-tag-changes nil notmuch-show-thread-id)) > - (apply 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes) > + (apply 'notmuch-tag (notmuch-show-get-messages-ids " or ") tag-changes) > (notmuch-show-mapc t > (lambda () > (let* ((current-tags (notmuch-show-get-tags)) > -- > 1.7.8.1 >