From: David Bremner <david@tethera.net>
To: Daniel <quite@hack.org>, Louis Rilling <l.rilling@av7.net>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 0/4 v4] lib: Maildir flags synchronization fixes
Date: Mon, 05 Nov 2012 22:16:36 -0400 [thread overview]
Message-ID: <87d2zro4qj.fsf@zancas.localnet> (raw)
In-Reply-To: <20121106001633.GA14918@kelebek.lublin.se>
Daniel <quite@hack.org> writes:
> On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote:
>> I pushed the first two patches in this series; the second two need to be
>> updated for the new "broken test" framework, and reviewed.
>
> And old one... What came of this patch?
>
> I came across it, having been annoyed by the fact that notmuch broke my reading
> habits by marking messages (in the mutt sense) as seen, which I hadn't really
> seen yet in mutt. I tried out the patch; it applied and seems to work. What can
> I do to make it be applied? Other than giving it some attention. I must say
> that I have zero insight in the test framework, but if that's what's needed
> from me...
The patches need to be reviewed for correctness and style. Typically any
non-trivial patch (or series) needs two reviews. You can see examples in
the archives of how this works. They are currently marked stale, which
is supposed to mean they no long apply. On the other hand, if they apply
for you, maybe that tagging is wrong (see http://notmuchmail.org/nmbug/
for more information about patch tagging).
By the way, it seems like commit b88030b might be relevant.
d
next prev parent reply other threads:[~2012-11-06 2:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 22:23 [PATCH 0/4 v4] lib: Maildir flags synchronization fixes Louis Rilling
2011-09-14 22:23 ` [PATCH 1/4] lib: Kill last usage of C++ type bool Louis Rilling
2011-09-14 22:23 ` [PATCH 2/4] tags_to_maildir_flags: Cleanup double assignement Louis Rilling
2011-11-22 0:41 ` David Bremner
2011-09-14 22:23 ` [PATCH 3/4] test: Adding non-maildir tags does not move message from new to cur Louis Rilling
2011-09-14 22:23 ` [PATCH 4/4] tags_to_maildir_flags: Don't rename if no flags change Louis Rilling
2012-12-08 19:15 ` [PATCH] test: Adding non-maildir tags does not move message from new to cur david
2012-12-08 22:14 ` Jani Nikula
2012-12-19 21:39 ` Michal Sojka
2012-11-06 0:16 ` [PATCH 0/4 v4] lib: Maildir flags synchronization fixes Daniel
2012-11-06 2:16 ` David Bremner [this message]
2012-11-06 13:35 ` Daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2zro4qj.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=l.rilling@av7.net \
--cc=notmuch@notmuchmail.org \
--cc=quite@hack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).