From: Austin Clements <amdragon@MIT.EDU>
To: Thomas Schwinge <thomas@schwinge.name>,
Carl Worth <cworth@cworth.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] notmuch.el:notmuch-search-process-filter: Rewritten. Cope with incomplete lines.
Date: Mon, 24 Jun 2013 18:43:41 -0400 [thread overview]
Message-ID: <87d2rbyvs2.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <87pqgtmxfi.fsf@kepler.schwinge.homeip.net>
On Tue, 15 Nov 2011, Thomas Schwinge <thomas@schwinge.name> wrote:
> Hi!
>
> On Thu, 10 Mar 2011 18:02:09 -0800, Carl Worth <cworth@cworth.org> wrote:
>> On Thu, 3 Feb 2011 00:56:39 +0100, Thomas Schwinge <thomas@schwinge.name> wrote:
>> > This issue has been lying in ambush as of 2009-11-24's commit
>> > 93af7b574598637c2766dd1f8ef343962c9a8efb.
>>
>> Thanks very much for tracking down this bug, Thomas. What a nasty bug to
>> have in notmuch!
>>
>> Your fix seems to drop the last thread from the search results
>> view. I've now committed a slightly modified fix that avoids that
>> problem. I also made the test case provide slightly cleaner results.
>>
>> Let me know if you see any problems.
>
> That is much better, thanks!
>
> But we're not there yet... %-| That is, today I hit another issue that
> appears to hide in the same elisp code. See ``Error: Unexpected output
> From notmuch search''. (And, thanks to eBay for long subject lines...)
>
> Unfortunately I'm totally out of time at the moment (final month of
> writing and wrapping up my diploma thesis), so I'm just dumping my state
> here, for now.
*snip*
I happened to notice that this is still marked as a bug. I'm marking it
as fixed. This code was completely rewritten to use the streaming JSON
parser (and now the streaming S-expression parser) and there's now a
test that feeds the process filter the search data one character at a
time to catch these sorts of buffer boundary bugs.
prev parent reply other threads:[~2013-06-24 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 21:02 [BUG] Emacs UI dropping every 25th line, roughly Thomas Schwinge
2011-01-30 21:14 ` Jesse Rosenthal
2011-02-02 16:12 ` Thomas Schwinge
2011-02-02 23:56 ` Thomas Schwinge
2011-02-02 23:56 ` [PATCH 1/2] New test: Emacs' forgetfulness Thomas Schwinge
2011-02-02 23:56 ` [PATCH 2/2] notmuch.el:notmuch-search-process-filter: Rewritten. Cope with incomplete lines Thomas Schwinge
2011-02-03 17:06 ` Austin Clements
2011-02-03 17:27 ` Thomas Schwinge
2011-03-11 2:09 ` Carl Worth
2011-03-11 2:02 ` Carl Worth
2011-11-15 11:34 ` Thomas Schwinge
2013-06-24 22:43 ` Austin Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2rbyvs2.fsf@awakening.csail.mit.edu \
--to=amdragon@mit.edu \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).