From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id F34C2431FC2 for ; Fri, 23 Aug 2013 01:37:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.401 X-Spam-Level: * X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CNbk3HRYZTtp for ; Fri, 23 Aug 2013 01:37:05 -0700 (PDT) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 0D093431FAE for ; Fri, 23 Aug 2013 01:37:05 -0700 (PDT) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1VCmrT-0001ci-0R; Fri, 23 Aug 2013 09:36:55 +0100 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) (envelope-from ) id 1VCmrS-00012V-OV; Fri, 23 Aug 2013 09:36:50 +0100 From: Mark Walters To: Jameson Graef Rollins , Istvan Marko , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net> References: <87fvu4fl25.fsf@servo.finestructure.net> User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Fri, 23 Aug 2013 09:36:49 +0100 Message-ID: <87d2p44xcu.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 93.97.24.31 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: 7cedcee375505232f81e04db53dd705d (of first 20000 bytes) X-SpamAssassin-Score: 0.6 X-SpamAssassin-SpamBar: / X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored 0.6 points. Summary of the scoring: * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * 1.0 FREEMAIL_REPLY From and body contain different freemails * -0.4 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2013 08:37:11 -0000 Jameson Graef Rollins writes: > On Fri, Aug 16 2013, Istvan Marko wrote: >> When text/html parts include images as multipart/related and the >> text/plain alternative is used these images can be completely hidden >> with no easy way to access them or even find out that they are there. >> >> Make notmuch-show-insert-part-multipart/related add buttons for all >> parts, the first one visible the rest hidden. > > Hey, Istvan. Thanks so much for this patch. It seems to be addressing > the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net. > > However, the behavior of the part button that now appears seems to be a > bit strange. Clicking/hitting enter on the part attempts to save it > rather than open it. I wouldn't be surprised if has nothing to do with > the correctness of this patch, though. So is it possible that the > button is not inserted in the most ideal way, or is there some other > issue preventing it from behaving properly (could it have to do with the > part being "inline"?)? Hi I think I have diagnosed this bug. There is a potential fix in id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com The bug is nothing to do with Istvan's patch: his patch just triggers the underlying bug in the lazy part handling. Best wishes Mark