From: Mark Walters <markwalters1009@gmail.com>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_emacs call post-command-hook
Date: Thu, 23 Jan 2014 17:35:57 +0000 [thread overview]
Message-ID: <87d2jizjlu.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1390354365-12311-1-git-send-email-david@tethera.net>
Hi
On Wed, 22 Jan 2014, David Bremner <david@tethera.net> wrote:
> From: Mark Walters <markwalters1009@gmail.com>
>
> The unread/read changes will use the post-command-hook. test_emacs
> does not call the post-command-hook. This adds a notmuch-test-progn
> which takes a list of commands as argument and executes them in turn
> but runs the post-command-hook after each one.
>
> The caller can batch operations (ie to stop post-command-hook from
> being interleaved) by wrapping the batch of operations inside a progn.
>
> We also explicitly run the post-command-hook before getting the output
> from a test; this makes sense as this will be a place the user would
> be seeing the information.
> ---
>
> What do you think about this alternate version? it allows
> notmuch-test-progn to have the same syntax as progn. It seems about
> the same level of complexity to me; fwiw I prefer the let over the
> dolist/setq.
This looks much nicer: a macro is definitely the right way to do this.
I might be inclined to replace the let... by a prog1 but would be happy
either way on that.
Best wishes
Mark
>
> test/test-lib.el | 13 +++++++++++++
> test/test-lib.sh | 2 +-
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 37fcb3d..a12ad97 100644
> --- a/test/test-lib.el
> +++ b/test/test-lib.el
> @@ -52,11 +52,13 @@
>
> (defun test-output (&optional filename)
> "Save current buffer to file FILENAME. Default FILENAME is OUTPUT."
> + (notmuch-post-command)
> (write-region (point-min) (point-max) (or filename "OUTPUT")))
>
> (defun test-visible-output (&optional filename)
> "Save visible text in current buffer to file FILENAME. Default
> FILENAME is OUTPUT."
> + (notmuch-post-command)
> (let ((text (visible-buffer-string)))
> (with-temp-file (or filename "OUTPUT") (insert text))))
>
> @@ -165,3 +167,14 @@ nothing."
>
> (t
> (notmuch-test-report-unexpected output expected)))))
> +
> +(defun notmuch-post-command ()
> + (run-hooks 'post-command-hook))
> +
> +(defmacro notmuch-test-progn (&rest body)
> + (cons 'progn
> + (mapcar
> + (lambda (x) `(let ((ret ,x))
> + (notmuch-post-command)
> + ret))
> + body)))
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 78af170..27dcb59 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -1118,7 +1118,7 @@ test_emacs () {
> rm -f OUTPUT
> touch OUTPUT
>
> - ${TEST_EMACSCLIENT} --socket-name="$EMACS_SERVER" --eval "(progn $@)"
> + ${TEST_EMACSCLIENT} --socket-name="$EMACS_SERVER" --eval "(notmuch-test-progn $@)"
> }
>
> test_python() {
> --
> 1.8.5.2
next prev parent reply other threads:[~2014-01-23 17:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 23:44 [PATCH 0/5] emacs: show: redesign unread/read logic Mark Walters
2013-12-14 23:44 ` [PATCH 1/5] emacs: show: make `seen' mean user viewed whole message Mark Walters
2013-12-14 23:44 ` [PATCH 2/5] emacs: show: add an update seen function to post-command-hook Mark Walters
2013-12-14 23:44 ` [PATCH 3/5] emacs: show: mark tags changed since buffer loaded Mark Walters
2013-12-14 23:44 ` [PATCH 4/5] emacs: tree: make the tree code force the mark read update Mark Walters
2013-12-14 23:44 ` [PATCH 5/5] test: make test_emacs call post-command-hook Mark Walters
2014-01-22 1:32 ` [PATCH] " David Bremner
2014-01-23 17:35 ` Mark Walters [this message]
2014-01-24 14:58 ` Tomi Ollila
2014-01-24 15:52 ` David Bremner
2014-01-24 18:34 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2jizjlu.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).