From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] build: compute subdirectories from the presence of Makefile.local
Date: Mon, 24 Mar 2014 23:14:17 -0300 [thread overview]
Message-ID: <87d2hbhvnq.fsf@zancas.localnet> (raw)
In-Reply-To: <1395276484-22363-2-git-send-email-david@tethera.net>
David Bremner <david@tethera.net> writes:
> This allows the fragile sed command in configure to be replaced with a somewhat
> less fragile find command.
> -subdirs = compat completion doc emacs lib parse-time-string \
> - performance-test util test test/test-databases
> +subdirs = $(dir $(shell find . -mindepth 2 -name Makefile.local))
I discovered a bug with this idea. There is actually an ordering
dependency for the sub Makefiles; in particular the targets of
test/Makefile.local use variables defined in lib/Makefile.local. I'll
have to think if/how this can be salvaged.
d
next prev parent reply other threads:[~2014-03-25 2:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 0:48 out of tree build fixes David Bremner
2014-03-20 0:48 ` [PATCH 1/3] build: compute subdirectories from the presence of Makefile.local David Bremner
2014-03-25 2:14 ` David Bremner [this message]
2014-03-25 11:40 ` [PATCH] build: move canonical list of subdirectories to configure script David Bremner
2014-03-25 12:31 ` Tomi Ollila
2014-03-25 12:59 ` Jani Nikula
2014-03-20 0:48 ` [PATCH 2/3] doc: fix out-of-tree build David Bremner
2014-03-20 0:48 ` [PATCH 3/3] test: use $(srcdir) instead of . as include path David Bremner
2014-03-20 10:29 ` out of tree build fixes Tomi Ollila
2014-03-22 17:27 ` Jani Nikula
2014-03-25 22:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2hbhvnq.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).