From: David Bremner <david@tethera.net>
To: Charles Celerier <cceleri@cs.stanford.edu>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.
Date: Thu, 08 May 2014 22:06:44 +0900 [thread overview]
Message-ID: <87d2fov2qj.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu>
Charles Celerier <cceleri@cs.stanford.edu> writes:
> test_begin_subtest 'comparing existing to exported symbols'
> -objdump -t $TEST_DIRECTORY/../lib/*.o | awk '$4 == ".text" && $6 ~ "^notmuch" {print $6}' | sort | uniq > ACTUAL
> +nm -g $TEST_DIRECTORY/../lib/*.o | sed -n 's/.*\s\+T\s\+_\(notmuch_.*\)/\1/p' | sort | uniq > ACTUAL
> sed -n 's/[[:blank:]]*\(notmuch_[^;]*\);/\1/p' $TEST_DIRECTORY/../notmuch.sym | sort | uniq > EXPORTED
Hmm. It seems like the _ there is wrong. It grabs all of the symbols
starting with _notmuch, which are symbols we _don't_ want exported.
It makes me wonder what ends up in "notmuch.sym" on MacOS, if that test
passes for you.
d
next prev parent reply other threads:[~2014-05-08 13:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 17:02 [PATCH 0/5] Improving portability to Mac OS X Charles Celerier
2014-05-06 17:02 ` [PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS Charles Celerier
2014-05-06 17:02 ` [PATCH 2/5] configure, test: Added variables for paths to true and false Charles Celerier
2014-05-06 17:02 ` [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later Charles Celerier
2014-05-06 17:02 ` [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-06 17:02 ` [PATCH 5/5] T360-symbol-hiding: Use nm instead of objdump Charles Celerier
2014-05-06 18:21 ` [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Tomi Ollila
2014-05-06 18:35 ` Charles Celerier
2014-05-06 19:09 ` Tomi Ollila
2014-05-06 18:26 ` [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later Tomi Ollila
2014-05-08 12:32 ` [PATCH 2/5] configure, test: Added variables for paths to true and false David Bremner
2014-05-08 15:00 ` Charles Celerier
2014-05-08 22:14 ` David Bremner
2014-05-17 21:46 ` [PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS David Bremner
2014-05-07 3:50 ` [PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-07 3:50 ` [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump Charles Celerier
2014-05-08 13:06 ` David Bremner [this message]
2014-05-08 15:03 ` Charles Celerier
2014-05-08 22:07 ` David Bremner
2014-05-09 1:20 ` Charles Celerier
2014-05-10 9:49 ` David Bremner
2014-05-10 14:55 ` Charles Celerier
2014-07-12 19:00 ` David Bremner
2014-07-13 15:36 ` [PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2fov2qj.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=cceleri@cs.stanford.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).