From: Lele Gaifax <lele@metapensiero.it>
To: notmuch@notmuchmail.org
Subject: Address completion in Emacs
Date: Fri, 12 Dec 2014 09:22:56 +0100 [thread overview]
Message-ID: <87d27p9t0f.fsf@nautilus.nautilus> (raw)
Hi all,
Yesterday I tweaked my Emacs configuration to use "ido-completing-read"
to select the right address in the minibuffer, and noticed what seems a
glitch in the related code.
To accomplish the goal, I implemented my own selection function
(defun esk-notmuch-address-selection-function (prompt addresses first)
"Use `ido-completing-read' to select one of the addresses."
(ido-completing-read prompt (cons first addresses)
nil nil nil 'notmuch-address-history))
and then assigned it to `notmuch-address-selection-function':
(setq notmuch-address-selection-function 'esk-notmuch-address-selection-function)
As you can see, I had to `cons' the two arguments, because the caller of
that function does something similar to the following (where `orig' is
the text entered before TAB-completion):
(options (notmuch-address-options orig))
(num-options (length options))
(chosen (funcall notmuch-address-selection-function
(format "Address (%s matches): " num-options)
(cdr options) (car options)))
and the standard `notmuch-address-selection-function' is defined like:
(defun notmuch-address-selection-function (prompt collection initial-input)
"Call (`completing-read'
PROMPT COLLECTION nil nil INITIAL-INPUT 'notmuch-address-history)"
(completing-read
prompt collection nil nil initial-input 'notmuch-address-history))
where that `initial-input' is not what I initially thought, the text
entered by the user, but rather the first completion candidate.
Wouldn't it be more "correct" to pass the unchanged `options' list and
the "real" `orig' text as `initial-input' to the customizable function
instead?
I understand that it may be undesiderable to break existing
configurations by rectifying the arguments in that way, and in such case
could we change the `initial-input' argument name to better reflect the
fact that it actually contains one possible candidate instead?
Thanks in advance for any clarification,
ciao, lele.
--
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele@metapensiero.it | -- Fortunato Depero, 1929.
next reply other threads:[~2014-12-12 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 8:22 Lele Gaifax [this message]
2014-12-12 12:14 ` Address completion in Emacs David Edmondson
2014-12-12 12:45 ` Lele Gaifax
2014-12-12 13:08 ` David Edmondson
2014-12-14 17:27 ` Tomi Ollila
-- strict thread matches above, loose matches on Subject: below --
2023-12-08 13:26 Address Completion " David Wen Riccardi-Zhu
2023-12-08 16:40 ` Sandra Snan
2023-12-09 2:05 ` David Wen Riccardi-Zhu
2023-12-09 8:26 ` Keith Amidon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d27p9t0f.fsf@nautilus.nautilus \
--to=lele@metapensiero.it \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).