From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7D41B6DE111A for ; Sun, 11 Sep 2016 10:29:39 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.007 X-Spam-Level: X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elRlVE77oklg for ; Sun, 11 Sep 2016 10:29:38 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 1E1966DE110A for ; Sun, 11 Sep 2016 10:29:37 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1bj8ZL-0006Aq-5t; Sun, 11 Sep 2016 13:29:27 -0400 Received: (nullmailer pid 5480 invoked by uid 1000); Sun, 11 Sep 2016 17:29:32 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH] test: make it possible to have multiple corpora In-Reply-To: <1473609824-6258-1-git-send-email-jani@nikula.org> References: <1473609824-6258-1-git-send-email-jani@nikula.org> Date: Sun, 11 Sep 2016 14:29:32 -0300 Message-ID: <87d1kapcoz.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Sep 2016 17:29:39 -0000 Jani Nikula writes: > We largely use the corpus under test/corpus for > testing. Unfortunately, many of our tests have grown to depend on > having exactly this set of messages, making it hard to add new message > files for testing specific cases. > > Move the basic corpus under tests/corpora/default, and make it > possible to add new, independent corpora along its side. This means > tons of renames with a few tweaks to add_email_corpus function in > test-lib.sh to let tests specify which corpus to use. > > --- > > This is to address id:87pooc1t4s.fsf@zancas.localnet It seems unobjectionable, but tbh I don't understand the problem it is solving. Do you plan to ship static test corpuses for individual test files, rather than using add_message? d