From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make it possible to have multiple corpora
Date: Sun, 11 Sep 2016 14:29:32 -0300 [thread overview]
Message-ID: <87d1kapcoz.fsf@zancas.localnet> (raw)
In-Reply-To: <1473609824-6258-1-git-send-email-jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> We largely use the corpus under test/corpus for
> testing. Unfortunately, many of our tests have grown to depend on
> having exactly this set of messages, making it hard to add new message
> files for testing specific cases.
>
> Move the basic corpus under tests/corpora/default, and make it
> possible to add new, independent corpora along its side. This means
> tons of renames with a few tweaks to add_email_corpus function in
> test-lib.sh to let tests specify which corpus to use.
>
> ---
>
> This is to address id:87pooc1t4s.fsf@zancas.localnet
It seems unobjectionable, but tbh I don't understand the problem it is
solving. Do you plan to ship static test corpuses for individual test
files, rather than using add_message?
d
next prev parent reply other threads:[~2016-09-11 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 16:03 [PATCH] test: make it possible to have multiple corpora Jani Nikula
2016-09-11 17:29 ` David Bremner [this message]
2016-09-11 18:29 ` Jani Nikula
2016-09-11 18:37 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1kapcoz.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).