unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jani Nikula <jani@nikula.org>
To: Brian Sniffen <bts@evenmere.org>, David Bremner <david@tethera.net>
Cc: Paul Wise <pabs@debian.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: consider files vanishing during notmuch new non-fatal
Date: Sat, 12 Nov 2016 22:35:30 +0200	[thread overview]
Message-ID: <87d1i0phbh.fsf@nikula.org> (raw)
In-Reply-To: <60C96E28-48D2-4307-A991-A68469733955@evenmere.org>

On Sat, 12 Nov 2016, Brian Sniffen <bts@evenmere.org> wrote:
>> 
>> OK, but the patch proposed works both for people who want to be notified
>> of this problem, and those that don't (with appropriate shell wrapping
>> checking the return code).  
>
> I think it will loop; how do I guarantee termination and indexing of
> all present messages if deletions cause errors?

Please note that we're talking about deletions and renames *between* the
scandir(3) call and going through the results it returns, during a
single invocation of 'notmuch new'. On the next run, scandir(3) won't
return the entry, and we'll think it's gone.

(Of course, if you keep deleting/renaming files and running 'notmuch
new' simultaneously all the time, you'll hit this on some other files on
the consequent runs, but then you asked for it...)

BR,
Jani.

  parent reply	other threads:[~2016-11-12 20:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04 12:46 [Paul Wise] Bug#843127: notmuch: race condition in `notmuch new`? David Bremner
2016-11-04 16:26 ` David Bremner
2016-11-13  1:51   ` Austin Clements
2016-11-14 18:44     ` J. Lewis Muir
2016-11-14 18:59       ` David Bremner
2016-11-04 18:47 ` Jani Nikula
2016-11-05  2:15   ` Paul Wise
2016-11-05 12:57     ` [PATCH] cli: consider files vanishing during notmuch new non-fatal Jani Nikula
2016-11-05 13:22       ` Paul Wise
2016-11-12 15:39         ` David Bremner
2016-11-12 16:04           ` Brian Sniffen
2016-11-12 16:10             ` David Bremner
2016-11-12 16:15               ` David Bremner
2016-11-12 21:08               ` Brian Sniffen
2016-11-12 21:36                 ` David Bremner
2016-11-12 20:35             ` Jani Nikula [this message]
2016-11-16 11:43       ` David Bremner
2016-11-21 20:14         ` [PATCH v2] " Jani Nikula
2016-11-26  2:44           ` [PATCH] cli/new: document new exit code David Bremner
2016-11-26  9:17             ` Jani Nikula
2016-11-26  9:18               ` [PATCH] test: check the handling of files vanishing between scandir and indexing Jani Nikula
2016-11-27  9:59                 ` [PATCH v2] " Jani Nikula
2016-11-29  2:16                   ` David Bremner
2016-11-29  7:31                     ` Tomi Ollila
2016-12-03 11:24                   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1i0phbh.fsf@nikula.org \
    --to=jani@nikula.org \
    --cc=bts@evenmere.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=pabs@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).