From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 109F06DE15ED for ; Tue, 14 Mar 2017 08:39:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.005 X-Spam-Level: X-Spam-Status: No, score=-0.005 tagged_above=-999 required=5 tests=[AWL=0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fCWGtrSqI7MU for ; Tue, 14 Mar 2017 08:39:55 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id B63416DE15C9 for ; Tue, 14 Mar 2017 08:39:54 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1cnoXW-00031p-3R; Tue, 14 Mar 2017 11:39:10 -0400 Received: (nullmailer pid 31180 invoked by uid 1000); Tue, 14 Mar 2017 15:39:50 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] test-databases: use wget or curl to download test databases In-Reply-To: <20170312125933.10316-1-tomi.ollila@iki.fi> References: <20170312125933.10316-1-tomi.ollila@iki.fi> Date: Tue, 14 Mar 2017 12:39:50 -0300 Message-ID: <87d1djn9yx.fsf@rocinante.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 15:39:56 -0000 Tomi Ollila writes: > Often Linux systems are shipped with wget(1) by default (and no curl). > > Many BSDs, macOS, and e.g. some Linux minimal/container images > comes with curl(1) (and no wget). > > Attempting to download with curl if wget is not available increases > the likelihood for this to succeed. the patch is OK for me. What I wondered was if we should switch to committing the test artifact(s) to a git branch (maybe even to master). Originally I was worried about accumulating binary blobs in git history, but it seems we rarely change this blob. Of course using git is problem for people who want to run the upgrade tests without a git checkout; I'm not sure how many of those people there are. The performance test corpus is large enough that I think the seperate download makes sense. I also hope that it will be updated to reflect more real world bottlenecks. d