From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test-databases: use wget or curl to download test databases
Date: Tue, 14 Mar 2017 12:39:50 -0300 [thread overview]
Message-ID: <87d1djn9yx.fsf@rocinante.cs.unb.ca> (raw)
In-Reply-To: <20170312125933.10316-1-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Often Linux systems are shipped with wget(1) by default (and no curl).
>
> Many BSDs, macOS, and e.g. some Linux minimal/container images
> comes with curl(1) (and no wget).
>
> Attempting to download with curl if wget is not available increases
> the likelihood for this to succeed.
the patch is OK for me. What I wondered was if we should switch to
committing the test artifact(s) to a git branch (maybe even to
master). Originally I was worried about accumulating binary blobs in git
history, but it seems we rarely change this blob. Of course using git
is problem for people who want to run the upgrade tests without a git
checkout; I'm not sure how many of those people there are.
The performance test corpus is large enough that I think the seperate
download makes sense. I also hope that it will be updated to reflect
more real world bottlenecks.
d
prev parent reply other threads:[~2017-03-14 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 12:59 [PATCH] test-databases: use wget or curl to download test databases Tomi Ollila
2017-03-12 18:31 ` [PATCH] test: verify test database v1 checksum in more portable way Tomi Ollila
2017-03-12 22:33 ` David Bremner
2017-03-13 19:32 ` Tomi Ollila
2017-03-14 15:39 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1djn9yx.fsf@rocinante.cs.unb.ca \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).